Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Demangling of Rust Symbols #36059

Merged
merged 1 commit into from
Aug 29, 2016
Merged

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Aug 27, 2016

This turns .. into ::, handles some more escapes and gets rid of unwanted underscores at the beginning of path elements.

Image of Diff

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

This turns `..` into `::`, handles some more escapes and gets rid of
unwanted underscores at the beginning of path elements.

![Image of Diff](http://puu.sh/qQIN3.png)
@alexcrichton
Copy link
Member

@bors: r+

Awesome, thanks!

@bors
Copy link
Contributor

bors commented Aug 28, 2016

📌 Commit 121b2fe has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 28, 2016

⌛ Testing commit 121b2fe with merge acd3f79...

bors added a commit that referenced this pull request Aug 28, 2016
Improve Demangling of Rust Symbols

This turns `..` into `::`, handles some more escapes and gets rid of unwanted underscores at the beginning of path elements.

![Image of Diff](http://puu.sh/qQIN3.png)
@bors bors merged commit 121b2fe into rust-lang:master Aug 29, 2016
CryZe added a commit to CryZe/rustc-demangle that referenced this pull request Sep 23, 2016
This turns `..` into `::`, handles some more escapes and gets rid of
unwanted underscores at the beginning of path elements.

![Image of Diff](http://puu.sh/qQIN3.png)
CryZe added a commit to CryZe/rustc-demangle that referenced this pull request Sep 23, 2016
This turns `..` into `::`, handles some more escapes and gets rid of
unwanted underscores at the beginning of path elements.

![Image of Diff](http://puu.sh/qQIN3.png)
alexcrichton added a commit to rust-lang/rustc-demangle that referenced this pull request Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants