Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style guide. #35124

Merged
merged 2 commits into from
Aug 27, 2016
Merged

Remove style guide. #35124

merged 2 commits into from
Aug 27, 2016

Conversation

steveklabnik
Copy link
Member

We originally imported this into the repository with the intent of
fixing it up. Instead, nothing happened.

Its appearance on rust-lang.org makes it seem semi-official, but it's
not. The rustfmt strike team will end up producing something like this
anyway, and leaving it around does nothing but mislead people.

r? @aturon

We originally imported this into the repository with the intent of
fixing it up. Instead, nothing happened.

Its appearance on rust-lang.org makes it seem semi-official, but it's
not. The rustfmt strike team will end up producing something like this
anyway, and leaving it around does nothing but mislead people.
@aturon
Copy link
Member

aturon commented Aug 25, 2016

Hm, I thought I commented on this here before, but: r=me.

To be clear, the API style guide won't be covered by the strike team, but it's something the libs team should work on and make more official. I'm fine removing this for now.

@steveklabnik
Copy link
Member Author

@bors: r=aturon rollup

(we talked about it briefly on IRC, that's why you remember saying something. I had forgotten to actually take care of it, though)

@bors
Copy link
Contributor

bors commented Aug 26, 2016

📌 Commit 57719e2 has been approved by aturon

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
Remove style guide.

We originally imported this into the repository with the intent of
fixing it up. Instead, nothing happened.

Its appearance on rust-lang.org makes it seem semi-official, but it's
not. The rustfmt strike team will end up producing something like this
anyway, and leaving it around does nothing but mislead people.

r? @aturon
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2016
Remove style guide.

We originally imported this into the repository with the intent of
fixing it up. Instead, nothing happened.

Its appearance on rust-lang.org makes it seem semi-official, but it's
not. The rustfmt strike team will end up producing something like this
anyway, and leaving it around does nothing but mislead people.

r? @aturon
@Manishearth
Copy link
Member

Needs 96d523d

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2016
bors added a commit that referenced this pull request Aug 27, 2016
Rollup of 7 pull requests

- Successful merges: #35124, #35877, #35953, #36002, #36004, #36005, #36014
- Failed merges:
@bors bors merged commit 57719e2 into rust-lang:master Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants