Incr. comp. dep-node for traits, tests #33998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests reveal that the edges are in some cases too strict.
To handle the general case, we include a vector of def-ids, so that we can account for things like `(Foo, Bar)` which references both `Foo` and `Bar`. This means it is not Copy, so re-jigger some APIs to use borrowing more intelligently.
This way we distinguish, in particular, `Foo: Sized` and `Bar: Sized`, which fixes rust-lang#33850.
nikomatsakis
changed the title
| TraitSelect(ref d) => op(d).map(TraitSelect), | ||
| TraitSelect(ref d, ref type_ds) => { | ||
| let d = try_opt!(op(d)); | ||
| let type_ds = try_opt!(type_ds.iter().map(|d| op(d)).collect()); |
There was a problem hiding this comment.
I don't understand why this works. Doesn't the argument to try_opt!() have to be an Option of something? But collect() will return a Vec?
There was a problem hiding this comment.
You can collect an iterator yielding Options into a single Option
There was a problem hiding this comment.
@jonas-schievink Oh, that's interesting. Thanks for enlightening me :)
There was a problem hiding this comment.
You can collect an iterator yielding Options into a single Option
best feature ever
|
LGTM! r=me with the typo fixed. I'll leave it up to you, if you want to get rid of the avoidable allocation in |
|
@bors r=mw |
|
📌 Commit e548c46 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 4, 2016
Incr. comp. dep-node for traits, tests Introduce new tests and also make dep-node for trait selection a bit more selective. Fixes #33850 r? @michaelwoerister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new tests and also make dep-node for trait selection a bit more selective.
Fixes #33850
r? @michaelwoerister