trivial tweaks to documentation (book) #33558
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Nope, that's it! |
| @@ -225,7 +225,7 @@ sense to put it into a function: | |||
| ```rust | |||
| # fn find(_: &str, _: char) -> Option<usize> { None } | |||
| // Returns the extension of the given file name, where the extension is defined | |||
| // as all characters proceeding the first `.`. | |||
| // as all characters following the first `.`. | |||
There was a problem hiding this comment.
I believe the proceeding/following distinction is a bug (but might be a English dialect distinction?).
precede/proceed are two different things, maybe that's what you're getting at? proceed and follow are synonyms. That said, "follow" might be more clear, so I'm fine with changing it.
|
@bors: r+ rollup thank you! |
|
📌 Commit 8e8f391 has been approved by |
…veklabnik trivial tweaks to documentation (book) These are small things I found while reading through The Book. The `<hash>` and `panic!` lines are simply to improve readability, while I believe the proceeding/following distinction is a bug (but might be a English dialect distinction?). I've read `rust/CONTRIBUTING`, i'm not sure if there is anything I need to do other than submit this PR. r? @steveklabnik
These are small things I found while reading through The Book. The
<hash>andpanic!lines are simply to improve readability, while I believe the proceeding/following distinction is a bug (but might be a English dialect distinction?).I've read
rust/CONTRIBUTING, i'm not sure if there is anything I need to do other than submit this PR.r? @steveklabnik