Add support for naked functions #32410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are stolen from @jackpot51's PR. |
|
tidy failure |
|
Fixed. |
|
r? @eddyb |
| @@ -376,6 +379,9 @@ pub const KNOWN_ATTRIBUTES: &'static [(&'static str, AttributeType, AttributeGat | |||
| // FIXME: #14406 these are processed in trans, which happens after the | |||
| // lint pass | |||
| ("cold", Whitelisted, Ungated), | |||
| ("naked", Whitelisted, Gated("naked_functions", | |||
| "the `#[naked]` attribute \ | |||
| is an experimental feature")), | |||
There was a problem hiding this comment.
Can you add a test that the feature gating works, i.e. you get an error by default?
|
@bors r+ |
|
📌 Commit 4869417 has been approved by |
| @@ -212,6 +212,9 @@ const KNOWN_FEATURES: &'static [(&'static str, &'static str, Option<u32>, Status | |||
| // rust runtime internal | |||
| ("unwind_attributes", "1.4.0", None, Active), | |||
|
|
|||
| // allow the use of `#[naked]` on functions. | |||
| ("naked_functions", "1.9.0", None, Active), | |||
There was a problem hiding this comment.
I think this should be Some(32408)
|
When will this be merged? |
|
@ticki You can see the queue of PRs to be tested & merged here: http://buildbot.rust-lang.org/homu/queue/rust |
bors
added a commit
that referenced
this pull request
Mar 23, 2016
Add support for naked functions See rust-lang/rfcs#1201 (comment) This PR adds `#[naked]` for marking naked functions.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rfcs#1201 (comment)
This PR adds
#[naked]for marking naked functions.