Rollup of 6 pull requests #28665
Merged
Rollup of 6 pull requests #28665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Sep 25, 2015
steveklabnik
commented
- Successful merges: Add note about Copy for drop() #28319, trpl: Refactor returning closures section #28588, Utf8Error::valid_up_to: make documented semantics more precise/useful #28637, Docs: &A and &mut A are references, not pointers #28652, Change the first line of the println macro doc #28654, Keep examples consistent #28655
- Failed merges: reference: Unsafe section does not fit under Functions #28621
Caught by Brian Smith: rust-lang#27774 (comment)
This makes the first lines of the print! and println! macros different. Previously, they would show up exactly the same in the documentation for the macros in libstd [1], with nothing about how one of them also prints a newline. [1]: https://doc.rust-lang.org/stable/std/#macros
Caught by Brian Smith: rust-lang#27774 (comment)
This was discovered by maggyero on #rust. In the [documentation for the macros in libstd](https://doc.rust-lang.org/stable/std/#macros), the first lines for `print!` and `println!` were exactly the same, with no mention of how one of them also emits a newline: <img width="622" alt="screen shot 2015-09-25 at 12 11 52" src="https://cloud.githubusercontent.com/assets/503760/10099409/465d509a-6381-11e5-9eb9-766f21a08c50.png"> This commit makes the first lines of those two macros different.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit f4dc6c7 has been approved by |
|
⌛ Testing commit f4dc6c7 with merge 69f27c8... |
bors
added a commit
that referenced
this pull request
Sep 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.