Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 839 for {HashMap, HashSet} #28094

Merged
merged 1 commit into from
Sep 1, 2015
Merged

Implement RFC 839 for {HashMap, HashSet} #28094

merged 1 commit into from
Sep 1, 2015

Conversation

apasel422
Copy link
Contributor

It appears that these impls were left out of #25989 by mistake.

r? @alexcrichton

I'm not sure what the stability markers for these should be.

@alexcrichton
Copy link
Member

Could you tag these impls with #[stable] since 1.4? Other than that r=me, thanks!

@apasel422
Copy link
Contributor Author

What should I use for the feature name?

@alexcrichton
Copy link
Member

It's fine to pick something relatively arbitrary like hash_extend_copy or something like that.

It appears that these impls were left out of #25989 by mistake.
@apasel422
Copy link
Contributor Author

Done.

@alexcrichton
Copy link
Member

@bors: r+ a73d27f

@bors
Copy link
Contributor

bors commented Sep 1, 2015

⌛ Testing commit a73d27f with merge 7d78f2d...

bors added a commit that referenced this pull request Sep 1, 2015
It appears that these impls were left out of #25989 by mistake.

r? @alexcrichton

I'm not sure what the stability markers for these should be.
@bors bors merged commit a73d27f into rust-lang:master Sep 1, 2015
@apasel422 apasel422 deleted the extend-hashmap branch September 1, 2015 02:57
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 15, 2015
@bluss
Copy link
Member

bluss commented Sep 15, 2015

Tagging for relnotes. Also small flag for this breaking type inference in a few cases, just like previous Extend<&T> additions. (And that's ok, we just need to keep it in mind).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants