std: Fix process spawn for arguments ending in backslashes on Windows #24820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
make_command_line
for the case of backslashes at the end of anargument requiring quotes. We must encode the command and arguments
such that
CommandLineToArgvW
recovers them in the spawned process.Simplify the logic by using a running count of backslashes as they
are encountered instead of looking ahead for quotes following them.
Extend
test_make_command_line
to additionally cover: