Eschew arena::Arena in regions-mock-tcx #21983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…holds cyclic structure (which the Arena API updated for dropck cannot handle).
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
spawned off of #21972 |
|
(also, really, anyone can review this. It is a trivial refactoring from one API to another.) |
|
@bors r+ e4a6 rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 6, 2015
…gions-mock-tcx, r=huonw Ported regions-mock-tcx to use TypedArena rather than Arena since it holds cyclic structure (which the Arena API updated for the Drop-Check-Rule cannot handle). Plus, the use of `arena::Arena` here really is not justified; the allocated values are all the same type anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported regions-mock-tcx to use TypedArena rather than Arena since it holds cyclic structure (which the Arena API updated for the Drop-Check-Rule cannot handle).
Plus, the use of
arena::Arenahere really is not justified; the allocated values are all the same type anyway.