std: Rename io to old_io #21543
std: Rename io to old_io #21543
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Note that this hasn't quite finished bootstrapping yet (lots of tests to take care of), but wanted to get this out there as I'll probably finish by the time it hits bors :) |
|
r? @aturon |
alexcrichton
force-pushed
the
old-io
branch
5 times, most recently
from
ebfbdf9
to
0e646ce
Compare
|
@bors: r+ 0e646ce And so it begins. |
|
🎉 |
|
@alexcrichton would this be a good time to rename |
|
@sfackler I talked with @aturon on IRC about this and we were basically on the fence about that now. Taking the strategy of |
|
Could anybody point me to design issues with the current |
|
This is part of io reform. It's not really a "rewrite", more a reorganization and slimming down of APIs (though there are a few deeper changes.) |
|
@alexcrichton so my concern is that when IO reform lands, people are going to update their trait imports, see it compiles and call it a day. Even if someone's aware of the change to |
|
@sfackler @alexcrichton OK, I'm basically persuaded by @sfackler's argument. It's another relatively easy breaking change (like the Want to roll that into this PR before it hits bors? |
alexcrichton
force-pushed
the
old-io
branch
5 times, most recently
from
e139a3a
to
7960221
Compare
|
@bors: r=aturon 7960221 |
|
@bors: r=aturon a1bfa26 |
|
⌛ Testing commit a1bfa26 with merge 618ec0e... |
In preparation for the I/O rejuvination of the standard library, this commit
renames the current `io` module to `old_io` in order to make room for the new
I/O modules. It is expected that the I/O RFCs will land incrementally over time
instead of all at once, and this provides a fresh clean path for new modules to
enter into as well as guaranteeing that all old infrastructure will remain in
place for some time.
As each `old_io` module is replaced it will be deprecated in-place for new
structures in `std::{io, fs, net}` (as appropriate).
This commit does *not* leave a reexport of `old_io as io` as the deprecation
lint does not currently warn on this form of use. This is quite a large breaking
change for all imports in existing code, but all functionality is retained
precisely as-is and path statements simply need to be renamed from `io` to
`old_io`.
[breaking-change]
|
💔 Test failed - auto-mac-64-opt |
In preparation for the I/O rejuvination of the standard library, this commit
renames the current `io` module to `old_io` in order to make room for the new
I/O modules. It is expected that the I/O RFCs will land incrementally over time
instead of all at once, and this provides a fresh clean path for new modules to
enter into as well as guaranteeing that all old infrastructure will remain in
place for some time.
As each `old_io` module is replaced it will be deprecated in-place for new
structures in `std::{io, fs, net}` (as appropriate).
This commit does *not* leave a reexport of `old_io as io` as the deprecation
lint does not currently warn on this form of use. This is quite a large breaking
change for all imports in existing code, but all functionality is retained
precisely as-is and path statements simply need to be renamed from `io` to
`old_io`.
[breaking-change]
|
💔 Test failed - auto-mac-64-opt |
|
@bors: r=aturon 93d2352 |
|
⌛ Testing commit 93d2352 with merge 231825c... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: r=aturon 39690eb |
|
⌛ Testing commit 39690eb with merge dbc7ad0... |
|
💔 Test failed - auto-mac-64-opt |
|
💔 Test failed - auto-win-64-nopt-t |
In preparation for the I/O rejuvination of the standard library, this commit
renames the current `io` module to `old_io` in order to make room for the new
I/O modules. It is expected that the I/O RFCs will land incrementally over time
instead of all at once, and this provides a fresh clean path for new modules to
enter into as well as guaranteeing that all old infrastructure will remain in
place for some time.
As each `old_io` module is replaced it will be deprecated in-place for new
structures in `std::{io, fs, net}` (as appropriate).
This commit does *not* leave a reexport of `old_io as io` as the deprecation
lint does not currently warn on this form of use. This is quite a large breaking
change for all imports in existing code, but all functionality is retained
precisely as-is and path statements simply need to be renamed from `io` to
`old_io`.
[breaking-change]
In preparation for upcoming changes to the `Writer` trait (soon to be called `Write`) this commit renames the current `write` method to `write_all` to match the semantics of the upcoming `write_all` method. The `write` method will be repurposed to return a `usize` indicating how much data was written which differs from the current `write` semantics. In order to head off as much unintended breakage as possible, the method is being deprecated now in favor of a new name. [breaking-change]
In preparation for the I/O rejuvination of the standard library, this commit
renames the current `io` module to `old_io` in order to make room for the new
I/O modules. It is expected that the I/O RFCs will land incrementally over time
instead of all at once, and this provides a fresh clean path for new modules to
enter into as well as guaranteeing that all old infrastructure will remain in
place for some time.
As each `old_io` module is replaced it will be deprecated in-place for new
structures in `std::{io, fs, net}` (as appropriate).
This commit does *not* leave a reexport of `old_io as io` as the deprecation
lint does not currently warn on this form of use. This is quite a large breaking
change for all imports in existing code, but all functionality is retained
precisely as-is and path statements simply need to be renamed from `io` to
`old_io`.
[breaking-change]
This makes racer compile again as of rustc 1.0.0-dev (d77f6d536 2015-01-27 11:07:26 +0000) See rust-lang/rust#21543 for details
This makes racer compile again as of rustc 1.0.0-dev (d77f6d536 2015-01-27 11:07:26 +0000) See rust-lang/rust#21543 for details
In preparation for the I/O rejuvination of the standard library, this commit
renames the current
iomodule toold_ioin order to make room for the newI/O modules. It is expected that the I/O RFCs will land incrementally over time
instead of all at once, and this provides a fresh clean path for new modules to
enter into as well as guaranteeing that all old infrastructure will remain in
place for some time.
As each
old_iomodule is replaced it will be deprecated in-place for newstructures in
std::{io, fs, net}(as appropriate).This commit does not leave a reexport of
old_io as ioas the deprecationlint does not currently warn on this form of use. This is quite a large breaking
change for all imports in existing code, but all functionality is retained
precisely as-is and path statements simply need to be renamed from
iotoold_io.[breaking-change]