Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "build/host" symlink comment #131279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Oct 5, 2024

It's needed and can't be removed, so make it clear where it's needed.

@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 5, 2024
@Noratrieb
Copy link
Member

what's the motivation? this seems like a small thing that makes it easier to work with bootstrap with no downsides other than a bit of easy to maintain code. or is there more to it?

@onur-ozkan
Copy link
Member Author

what's the motivation?

It says Make a symbolic link so we can use a consistent directory in the documentation., which doesn't really make sense as I explain in the PR description.

@onur-ozkan
Copy link
Member Author

onur-ozkan commented Oct 5, 2024

this seems like a small thing that makes it easier to work with bootstrap with no downsides other than a bit of easy to maintain code. or is there more to it?

How does it make things easier? The host target is always the same and they are at the same directory level. You just need to type the first couple of letters of the host triple and press TAB instead of writing 'host'.

@Noratrieb
Copy link
Member

that was just a vague feeling, but it doesn't matter, I just remembered that we rely on this for the rust analyzer config:

"${workspaceFolder}/build/host/rustfmt/bin/rustfmt",

@compiler-errors
Copy link
Member

I use build/host all the time. Please don't remove it for literally no reason, lmao.

@onur-ozkan
Copy link
Member Author

that was just a vague feeling, but it doesn't matter, I just remembered that we rely on this for the rust analyzer config:

"${workspaceFolder}/build/host/rustfmt/bin/rustfmt",

Nice. It seems more useful than "writing consistent docs". I will revert the removal and update the doc.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan changed the title remove "build/host" symlink update "build/host" symlink comment Oct 5, 2024
@Noratrieb
Copy link
Member

cool!
borsrplus in the style of the ToysRUs logo

@bors
Copy link
Contributor

bors commented Oct 5, 2024

📌 Commit 4f50efd has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2024
@Noratrieb
Copy link
Member

(I updated the PR description for you)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants