Fix linkage1 test which fails due to --as-needed #12983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you put wording such as this in both the commit message and as a comment in the test?
|
It appears that the --as-needed flag to linkers will not pull in a dynamic library unless it satisfies a non weak undefined symbol. The linkage1 test was creating a dynamic library where it was only used for a weak-symbol as part of an executable, so the dynamic library was getting discarded. This commit adds another symbol to the library which satisfies a strong undefined symbol, so the library is pulled in to resolve the weak reference.
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Sep 6, 2022
turn `unwrap_or` into `unwrap_or_else` and vice versa closes rust-lang#12983
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 27, 2024
use short message format in integration test While checking rust-lang#12983, bors came upon a cargo change that put "E0463" into the standard error (as part of a test case code snippet), which the integration test picked up to fail the build. Talk about unforeseen consequences. So this PR just changes the integration test to use short message format in order to not include the code snippets in the output. Hopefully that will fix the problem. r? `@Alexendoo` --- changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 11, 2024
Implement a lint to replace manual bit rotations with rotate_left/rot… Fixes rust-lang#6861 r? `@llogiq` --- changelog: add [`manual_rotate`] lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.