-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize const_refs_to_static
#129759
base: master
Are you sure you want to change the base?
Stabilize const_refs_to_static
#129759
Conversation
rustbot has assigned @petrochenkov. Use |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Looks like FCP in #128183 (comment) has completed yesterday. |
The implementation seems trivial, so I can review and approve, but if you want someone from the const eval group to do that, feel free to reassign. |
This also needs a rebase and a fix for the error index. |
c100748
to
8fb32f6
Compare
This comment has been minimized.
This comment has been minimized.
8fb32f6
to
c25bec4
Compare
This comment has been minimized.
This comment has been minimized.
c25bec4
to
13b168c
Compare
Some changes occurred in diagnostic error codes |
This comment has been minimized.
This comment has been minimized.
13b168c
to
41dc5d3
Compare
@rustbot ready
|
@rustbot author |
f8c9dce
to
7b42f6e
Compare
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
7b42f6e
to
eeaaa21
Compare
Please avoid unnecessary (i.e., not conflict-induced) rebases over master. Use |
This comment has been minimized.
This comment has been minimized.
@rustbot ready
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ah, so it was concerned about the reference, not the integer. Apologies for misleading you. I don't know a way to deal with that aside from normalization. |
To make sure that the tests still run on the critical architectures, I am going to @bors try |
…s-to-static, r=<try> Stabilize `const_refs_to_static` Meanwhile, I am cooking a sub-section in the language reference.
⌛ Trying commit 539b624 with merge 47e91977e7dcb439530140bf1a5a3e6c37e8b9fa... |
I think it should be good now, thanks. :) Please squash the commits a little. |
update tests fix bitwidth-sensitive stderr output use build-fail for asm tests
29fbe2e
to
7d9582a
Compare
@RalfJung Thanks for the reviews! I have squashed the commit and tweaked the commit wording a bit. |
LGTM. |
Close #128183
Tracked by #119618
cc @nikomatsakis
Meanwhile, I am cooking a sub-section in the language reference.