Ensure that tail expr receive lifetime extension #129627
Open
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jieyouxu |
rustbot
added
S-waiting-on-review
traviscross
reviewed
Aug 27, 2024
| @@ -1,4 +1,10 @@ | |||
| //@ check-pass | |||
| //@ run-pass | |||
There was a problem hiding this comment.
Any reason this test needs to run?
There was a problem hiding this comment.
I forgot about the //@ check-run-results. I will add it later.
There was a problem hiding this comment.
I also want to make sure that the print-out makes sense.
Open
14 tasks
jieyouxu
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Suggestion: could you add a little bit of context/comment for the significance of
let f = if true { &temp() } else { &temp() };Bonus points if there's any reference/docs this can link to.
jieyouxu
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jieyouxu @traviscross
It just came to me that we should add a test to make sure that we honor the contract from the temporary lifetime rule #121346. We should continue to implement this rule in Edition 2021 onward and shorter tail expression lifetime should not override it.
This is a small PR to improve our assurance and establish a stronger contract.
Tracked by #123739