Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-update to LLVM 19 rc2 #129068

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Re-update to LLVM 19 rc2 #129068

merged 1 commit into from
Aug 16, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Aug 13, 2024

The update in #128677 was accidentally reverted in #128962.

Fixes #129064
r? nikic

The update in rust-lang#128677 was accidentally reverted in rust-lang#128962.
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2024
@compiler-errors
Copy link
Member

Why didn't rustbot alert on modified submodules in that PR? :///

@bors r+

@bors
Copy link
Contributor

bors commented Aug 14, 2024

📌 Commit 5ef895e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024
@compiler-errors
Copy link
Member

@bors rollup=never (mirroring the original pr)

@DianQK
Copy link
Member

DianQK commented Aug 14, 2024

Why didn't rustbot alert on modified submodules in that PR? :///

@bors r+

I suspect it's because the force push diff didn't include it: https://github.com/rust-lang/rust/compare/11cf5e808b75fdc9db5c54b2420f130a7254219f..70e0f69632591add54bc1e4d625e7bbb9fa02095.diff

@workingjubilee
Copy link
Member

Yeah, I'm surprised given that usually rustbot is quite assiduous at whining about that sort of thing.

@bors
Copy link
Contributor

bors commented Aug 16, 2024

⌛ Testing commit 5ef895e with merge a73bc4a...

@bors
Copy link
Contributor

bors commented Aug 16, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing a73bc4a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2024
@bors bors merged commit a73bc4a into rust-lang:master Aug 16, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 16, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a73bc4a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.4%, 1.0%] 7
Regressions ❌
(secondary)
1.2% [0.2%, 2.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [0.4%, 1.0%] 7

Max RSS (memory usage)

Results (primary -3.1%, secondary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
-3.1% [-3.1%, -3.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.1% [-3.1%, -3.1%] 1

Cycles

Results (secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.7% [2.1%, 5.6%] 13
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.1%, -1.9%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.393s -> 751.349s (-0.01%)
Artifact size: 339.23 MiB -> 337.10 MiB (-0.63%)

@rustbot rustbot added the perf-regression Performance regression. label Aug 16, 2024
@Mark-Simulacrum Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Aug 19, 2024
@Mark-Simulacrum
Copy link
Member

Results continue to look like bimodality.

@cuviper cuviper deleted the llvm19rc2 branch September 4, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM downgraded by accident
9 participants