Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rustc's std copy #128986

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Aug 11, 2024

This removes rustc's std copy if we're statically linking std into rustc_driver. This copy is not needed after #122362.

try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 11, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Aug 12, 2024

Could you please comment this line in this PR, to enable post-optimization tests in the x64 Linux dist runner? Then we can try the dist tests in try builds.

@lqd
Copy link
Member

lqd commented Aug 12, 2024

This PR is still a WIP in order to run tests/debug/try alternatives on builders, right? As it currently looks like dd3f757 which failed in the previous PR.

@Zoxc
Copy link
Contributor Author

Zoxc commented Aug 12, 2024

I haven't tracked down the reason for the test failure yet. Does post-optimization tests specify the final binary as stage0-sysroot? Then runs tests as stage0 with a new std build?

@Kobzol
Copy link
Contributor

Kobzol commented Aug 12, 2024

Yeah, post-optimization tests essentially take the sysroot created in the dist step, and try to run tests with it (using the "allow stage0 sysroot" hack). It is implemented here.

@Kobzol
Copy link
Contributor

Kobzol commented Sep 4, 2024

It seems like this could progress after #129941. I tried it locally and we can remove the stage != "0" check and do this. And then see what tests break :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants