Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform ThinLTO on x86_64-pc-windows-msvc dist builder #128947

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Perform ThinLTO on x86_64-pc-windows-msvc dist builder #128947

wants to merge 2 commits into from
+8 −2

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Aug 10, 2024

This reenables ThinLTO on x86_64-pc-windows-msvc.

Depends on #122790

@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 10, 2024
@jieyouxu
Copy link
Member

FYI @rust-lang/infra

@lqd
Copy link
Member

lqd commented Aug 11, 2024

I don't think we're in a situation where we can yet have a definite yes/no answer for this PR yet.

Marking as blocked on #122790. The discussions and underlying issues there shouldn't be split amongst PRs.

@rustbot blocked

@rustbot rustbot added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2024
@Zoxc Zoxc mentioned this pull request Aug 11, 2024
Open
@bors
Copy link
Contributor

bors commented Sep 20, 2024

☔ The latest upstream changes (presumably #130506) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zoxc @rustbot @jieyouxu @lqd @bors @TaKO8Ki