run-make: enable msvc for redundant-libs #128804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
This comment was marked as outdated.
This comment was marked as outdated.
|
Oh, bors is having a moment. Since the mingw jobs were (presumably) succeeding before I think I'll change this to be MSVC only... |
|
let's try again @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 8, 2024
run-make: enable msvc for redundant-libs The issue here was that `foo` was not exporting any functions therefore creating an import library was unnecessary and elided by the linker. I fixed it by exporting the functions. try-job: x86_64-msvc try-job: i686-msvc
28 tasks
jieyouxu
approved these changes
Aug 8, 2024
|
☀️ Try build successful - checks-actions |
|
I was confused too. A DLL that doesn't export functions did not occur to me until after I had banged my head on the keyboard a few times. @bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 8, 2024
run-make: enable msvc for redundant-libs The issue here was that `foo` was not exporting any functions therefore creating an import library was unnecessary and elided by the linker. I fixed it by exporting the functions. try-job: x86_64-msvc try-job: i686-msvc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 8, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#128795 (Update E0517 message to reflect RFC 2195.) - rust-lang#128804 (run-make: enable msvc for redundant-libs) - rust-lang#128807 (run-make: run fmt-write-bloat on Windows) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#128616 (Don't inline tainted MIR bodies) - rust-lang#128804 (run-make: enable msvc for redundant-libs) - rust-lang#128823 (run-make: enable msvc for staticlib-dylib-linkage) - rust-lang#128824 (Update compiler-builtins version to 0.1.118) Failed merges: - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2024
Rollup merge of rust-lang#128804 - ChrisDenton:redudant, r=jieyouxu run-make: enable msvc for redundant-libs The issue here was that `foo` was not exporting any functions therefore creating an import library was unnecessary and elided by the linker. I fixed it by exporting the functions. try-job: x86_64-msvc try-job: i686-msvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was that
foowas not exporting any functions therefore creating an import library was unnecessary and elided by the linker.I fixed it by exporting the functions.
try-job: x86_64-msvc
try-job: i686-msvc