Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deduplicating unreachable blocks, erase the source information. #128628

Merged
merged 1 commit into from
Aug 19, 2024

Commits on Aug 4, 2024

  1. When deduplicating unreachable blocks, erase the source information.

    After deduplication the block conceptually belongs to multiple locations
    in the source. Although these blocks are unreachable, in rust-lang#123341 we did
    come across a real side effect, an unreachable block that survives into
    the compiled code can cause a debugger to set a breakpoint on the wrong
    instruction. Erasing the source information ensures that a debugger will
    never be misled into thinking that the unreachable block is worth setting
    a breakpoint on, especially after rust-lang#128627.
    
    Technically we don't need to erase the source information if all the
    deduplicated blocks have identical source information, but tracking
    that seems like more effort than it's worth.
    khuey committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    709406f View commit details
    Browse the repository at this point in the history