Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the use of CiEnv #128342

Merged
merged 1 commit into from
Jul 30, 2024
Merged

simplify the use of CiEnv #128342

merged 1 commit into from
Jul 30, 2024

Conversation

onur-ozkan
Copy link
Member

self-explanatory

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@onur-ozkan onur-ozkan changed the title simply the use of CiEnv simplify the use of CiEnv Jul 29, 2024
@onur-ozkan
simplify the use of CiEnv
06d64ea 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@Kobzol
Copy link
Contributor

Kobzol commented Jul 29, 2024 •
edited
Loading

I wanted to do something like this before, but I thought that keeping it explicit to e.g. stub it out in tests or something. But it's probably gonna take some time until we can write such granular tests in bootstrap 😆 And there's probably not that much to test about this anyway.

@bors r+ rollup

r? @Kobzol

@bors
Copy link
Contributor

bors commented Jul 29, 2024

📌 Commit 06d64ea has been approved by Kobzol

It is now in the queue for this repository.

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2024

Failed to set assignee to Kobzo: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2024
@rustbot rustbot assigned Kobzol and unassigned Mark-Simulacrum Jul 29, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 29, 2024
@bors
Auto merge of rust-lang#128360 - matthiaskrgr:rollup-wwy5mkj, r=matth…
368e2fd 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126247 (rustdoc: word wrap CamelCase in the item list table and sidebar)
 - rust-lang#128104 (Not lint pub structs without pub constructors intentionally)
 - rust-lang#128153 (Stop using `MoveDataParamEnv` for places that don't need a param-env)
 - rust-lang#128284 (Stabilize offset_of_nested)
 - rust-lang#128342 (simplify the use of `CiEnv`)
 - rust-lang#128355 (triagebot: make sure Nora is called Nora)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4d78d11 into rust-lang:master Jul 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024
@rust-timer
Unrolled build for rust-lang#128342
a32356a 
Rollup merge of rust-lang#128342 - onur-ozkan:ci-env-usage, r=Kobzol

simplify the use of `CiEnv`

self-explanatory
@onur-ozkan onur-ozkan deleted the ci-env-usage branch July 30, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @Kobzol @bors @Mark-Simulacrum