Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn an unreachable code path into an ICE #128189

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 25, 2024

We're probably replacing the resolution with a Res::Err nowadays instead of just erroring but keeping the Res, so this code path should be unreachable

@rustbot
Copy link
Collaborator

rustbot commented Jul 25, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 25, 2024
@compiler-errors
Copy link
Member

We indeed are (#128020)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 25, 2024

📌 Commit 0706cc6 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 25, 2024
…-errors

Turn an unreachable code path into an ICE

We're probably replacing the resolution with a `Res::Err` nowadays instead of just erroring but keeping the `Res`, so this code path should be unreachable
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126908 (Use Cow<'static, str> for InlineAsmTemplatePiece::String)
 - rust-lang#127999 (Inject arm32 shims into Windows metadata generation)
 - rust-lang#128137 (CStr: derive PartialEq, Eq; add test for Ord)
 - rust-lang#128185 (Fix a span error when parsing a wrong param of function.)
 - rust-lang#128187 (Fix 1.80.0 version in RELEASES.md)
 - rust-lang#128189 (Turn an unreachable code path into an ICE)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cf1ce4b into rust-lang:master Jul 25, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2024
Rollup merge of rust-lang#128189 - oli-obk:tainting_stuff, r=compiler-errors

Turn an unreachable code path into an ICE

We're probably replacing the resolution with a `Res::Err` nowadays instead of just erroring but keeping the `Res`, so this code path should be unreachable
@rustbot rustbot added this to the 1.82.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants