Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate --print link-args output with newline #127512

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Terminate --print link-args output with newline #127512

merged 2 commits into from
Jul 17, 2024

Conversation

eggyal
Copy link
Contributor

@eggyal eggyal commented Jul 9, 2024

Fixes #127507

@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 9, 2024
@Urgau
Copy link
Member

Urgau commented Jul 9, 2024

Would be good to update tests/run-make/link-arg/rmake.rs to verify that there is indeed a new-line.

@compiler-errors
Copy link
Member

yeah, r=me after adding a test

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2024
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jul 9, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@eggyal
Copy link
Contributor Author

eggyal commented Jul 9, 2024

Test added. @rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2024
@eggyal
Copy link
Contributor Author

eggyal commented Jul 17, 2024

Pretty sure I don't have permission to do this, but given #127512 (comment)... @bors r=compiler-errors rollup

@bors
Copy link
Contributor

bors commented Jul 17, 2024

@eggyal: 🔑 Insufficient privileges: Not in reviewers

@bors
Copy link
Contributor

bors commented Jul 17, 2024

@eggyal: 🔑 Insufficient privileges: not in try users

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 17, 2024

📌 Commit f96f68f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2024
@tgross35 tgross35 mentioned this pull request Jul 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2024
@bors
Auto merge of rust-lang#127840 - tgross35:rollup-jfkg1dq, r=tgross35
a28b35e 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#125206 (Simplify environment variable examples)
 - rust-lang#126271 (Skip fast path for dec2flt when optimize_for_size)
 - rust-lang#126776 (Clean up more comments near use declarations)
 - rust-lang#127444 (`impl Send + Sync` and override `count` for the `CStr::bytes` iterator)
 - rust-lang#127512 (Terminate `--print link-args` output with newline)
 - rust-lang#127792 (std: Use `read_unaligned` for reads from DWARF)
 - rust-lang#127807 (Use futex.rs for Windows thread parking)
 - rust-lang#127833 (zkvm: add `#[forbid(unsafe_op_in_unsafe_fn)]` in `stdlib`)
 - rust-lang#127836 (std: Forbid unwrapped unsafe ops in xous and uefi modules)

Failed merges:

 - rust-lang#127813 (Prevent double reference in generic futex)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8840d30 into rust-lang:master Jul 17, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2024
@rust-timer
Unrolled build for rust-lang#127512
f01ddf0 
Rollup merge of rust-lang#127512 - eggyal:newline-terminate-print-linkargs, r=compiler-errors

Terminate `--print link-args` output with newline

Fixes rust-lang#127507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

--print link-args does not print a newline
5 participants
@eggyal @rustbot @Urgau @compiler-errors @bors