Tweak output of import suggestions #126371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
fmease
approved these changes
Jun 13, 2024
| @@ -2,9 +2,19 @@ | |||
| // | |||
| // This is a regression test for #83564. | |||
| // For some reason, Rust 2018 or higher is required to reproduce the bug. | |||
There was a problem hiding this comment.
Huh, odd. Might be worth investigating some time.
fmease
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors r=fmease |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2024
Tweak output of import suggestions When both `std::` and `core::` items are available, only suggest the `std::` ones. We ensure that in `no_std` crates we suggest `core::` items. Ensure that the list of items suggested to be imported are always in the order of local crate items, `std`/`core` items and finally foreign crate items. Tweak wording of import suggestion: if there are multiple items but they are all of the same kind, we use the kind name and not the generic "items". Fix rust-lang#83564.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments) - rust-lang#126088 ([1/2] clean-up / general improvements) - rust-lang#126238 (Fix Miri sysroot for `x run`) - rust-lang#126315 (Add pub struct with allow(dead_code) into worklist) - rust-lang#126360 (Uplift `structural_traits.rs` into the new trait solver) - rust-lang#126371 (Tweak output of import suggestions) - rust-lang#126388 (const-eval: make lint scope computation consistent) - rust-lang#126390 (Fix wording in {checked_}next_power_of_two) - rust-lang#126392 (Small style improvement in `gvn.rs`) - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`) r? `@ghost` `@rustbot` modify labels: rollup
|
I'm not sure what the rustdoc test error is. I cannot replicate by running |
When both `std::` and `core::` items are available, only suggest the `std::` ones. We ensure that in `no_std` crates we suggest `core::` items. Ensure that the list of items suggested to be imported are always in the order of local crate items, `std`/`core` items and finally foreign crate items. Tweak wording of import suggestion: if there are multiple items but they are all of the same kind, we use the kind name and not the generic "items". Fix rust-lang#83564.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments) - rust-lang#126088 ([1/2] clean-up / general improvements) - rust-lang#126238 (Fix Miri sysroot for `x run`) - rust-lang#126315 (Add pub struct with allow(dead_code) into worklist) - rust-lang#126360 (Uplift `structural_traits.rs` into the new trait solver) - rust-lang#126371 (Tweak output of import suggestions) - rust-lang#126388 (const-eval: make lint scope computation consistent) - rust-lang#126390 (Fix wording in {checked_}next_power_of_two) - rust-lang#126392 (Small style improvement in `gvn.rs`) - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
Rollup merge of rust-lang#126371 - estebank:suggest-core, r=fmease Tweak output of import suggestions When both `std::` and `core::` items are available, only suggest the `std::` ones. We ensure that in `no_std` crates we suggest `core::` items. Ensure that the list of items suggested to be imported are always in the order of local crate items, `std`/`core` items and finally foreign crate items. Tweak wording of import suggestion: if there are multiple items but they are all of the same kind, we use the kind name and not the generic "items". Fix rust-lang#83564.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both
std::andcore::items are available, only suggest thestd::ones. We ensure that inno_stdcrates we suggestcore::items.Ensure that the list of items suggested to be imported are always in the order of local crate items,
std/coreitems and finally foreign crate items.Tweak wording of import suggestion: if there are multiple items but they are all of the same kind, we use the kind name and not the generic "items".
Fix #83564.