-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::unix::stack_overflow::drop_handler addressing todo through libc … #126207
base: master
Are you sure you want to change the base?
Conversation
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
The constant does not exist on Android yet, I believe, so we still need the workaround. But maybe you could gate it to be Android-only? |
ah true, I misread one level of the libc crate. |
e5b56ed
to
0e02247
Compare
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh? why is this constant not available on both android and linux?
That FIXME was for removing a novel definition, not merely using |
@bors r- |
adding here |
Thank you. |
☔ The latest upstream changes (presumably #127153) made this pull request unmergeable. Please resolve the merge conflicts. |
@devnexen any updates on this? thanks |
Well I see it is fixed on libc main branch only but not the stable branch I ll see for a backport. |
…update