Rollup of 10 pull requests #125588

workingjubilee · 2024-05-26T21:43:02Z

Successful merges:

Only allow immutable statics with #[linkage] #125046 (Only allow immutable statics with #[linkage])
Don't continue probing for method if in suggestion and autoderef hits ambiguity #125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity)
Don't skip out of inner const when looking for body for suggestion #125469 (Don't skip out of inner const when looking for body for suggestion)
cleanup dependence of ExtCtxt in transcribe when macro expansion #125530 (cleanup dependence of ExtCtxt in transcribe when macro expansion)
clean-up: remove deprecated field dist.missing-tools #125535 (clean-up: remove deprecated field dist.missing-tools)
crashes: increment the number of tracked ones #125539 (crashes: increment the number of tracked ones)
Also mention my-self for other check-cfg docs changes #125544 (Also mention my-self for other check-cfg docs changes)
Simplify the unchecked_sh[lr] ub-checks a bit #125559 (Simplify the unchecked_sh[lr] ub-checks a bit)
Notify T-rustdoc for beta-accepted and stable-accepted too #125566 (Notify T-rustdoc for beta-accepted and stable-accepted too)
Avoid a FieldIdx::from_usize in InstSimplify #125582 (Avoid a FieldIdx::from_usize in InstSimplify)

r? @ghost
@rustbot modify labels: rollup

… ambiguity

It's been 5 months since this field was deprecated. Signed-off-by: onur-ozkan <work@onurozkan.dev>

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed.

…r=cjgillot Only allow immutable statics with #[linkage]

…ig-in-sugg, r=jieyouxu Don't continue probing for method if in suggestion and autoderef hits ambiguity The title is somewhat self-explanatory. When we hit ambiguity in method autoderef steps, we previously would continue to probe for methods if we were giving a suggestion. This seems useless, and causes an ICE when we are not able to unify the receiver later on in confirmation. Fixes rust-lang#125432

…nst-body, r=cjgillot Don't skip out of inner const when looking for body for suggestion Self-explanatory title, I'll point out the important logic in an inline comment. Fixes rust-lang#125370

cleanup dependence of `ExtCtxt` in transcribe when macro expansion part of rust-lang#125356 We can remove `transcribe`’s dependence on `ExtCtxt` to facilitate subsequent work (such as moving macro expansion into the incremental compilation system) r? `@petrochenkov` Thanks for the reviewing!

…, r=clubby789 clean-up: remove deprecated field `dist.missing-tools` It's been 5 months since this field was deprecated.

crashes: increment the number of tracked ones r? `@jieyouxu`

…ific, r=jieyouxu Also mention my-self for other check-cfg docs changes This PR adds a mention for my-self for the recently added `src/doc/rustc/src/check-cfg` directory. *I had to add a second mention just for the directory since [`Path::starts_with`](https://doc.rust-lang.org/std/path/struct.Path.html#method.starts_with) as used by [triagebot](https://github.com/rust-lang/triagebot/blob/48f29f351cae774caa90f555fbbc6d0df7dce80e/src/handlers/mentions.rs#L69), matches on path components and so can never return true for a file and directory at the same time.*

…=workingjubilee Simplify the `unchecked_sh[lr]` ub-checks a bit It can use the constant in the check, rather than passing it as a parameter.

…meGomez Notify T-rustdoc for beta-accepted and stable-accepted too Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed. r? `@GuillaumeGomez`

Avoid a `FieldIdx::from_usize` in InstSimplify Just a tiny cleanup I noticed in passing while looking at something unrelated.

workingjubilee · 2024-05-26T21:44:05Z

@bors p=10 r+ rollup=never

bors · 2024-05-26T21:44:08Z

📌 Commit b2d7f77 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-05-26T21:44:09Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors · 2024-05-26T21:45:55Z

⌛ Testing commit b2d7f77 with merge a62ffec...

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#125046 (Only allow immutable statics with #[linkage]) - rust-lang#125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity) - rust-lang#125469 (Don't skip out of inner const when looking for body for suggestion) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125535 (clean-up: remove deprecated field `dist.missing-tools`) - rust-lang#125539 (crashes: increment the number of tracked ones) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) - rust-lang#125566 (Notify T-rustdoc for beta-accepted and stable-accepted too) - rust-lang#125582 (Avoid a `FieldIdx::from_usize` in InstSimplify) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-05-26T21:47:06Z

💔 Test failed - checks-actions

workingjubilee · 2024-05-26T21:47:58Z

what.

@bors retry

bors · 2024-05-26T21:49:24Z

⌛ Testing commit b2d7f77 with merge 80de5e6...

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#125046 (Only allow immutable statics with #[linkage]) - rust-lang#125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity) - rust-lang#125469 (Don't skip out of inner const when looking for body for suggestion) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125535 (clean-up: remove deprecated field `dist.missing-tools`) - rust-lang#125539 (crashes: increment the number of tracked ones) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) - rust-lang#125566 (Notify T-rustdoc for beta-accepted and stable-accepted too) - rust-lang#125582 (Avoid a `FieldIdx::from_usize` in InstSimplify) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2024-05-26T21:51:19Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

workingjubilee · 2024-05-26T21:53:54Z

@rust-log-analyzer That's completely useless, buddy.

workingjubilee · 2024-05-26T21:59:20Z

seemed to be just a straight-up failure of the job to be picked up, so despite happening for x86_64-msvc I don't think it was related to #125583

bors · 2024-05-26T22:06:59Z

💔 Test failed - checks-actions

rust-log-analyzer · 2024-05-26T22:09:49Z

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#17 exporting to docker image format
#17 sending tarball 32.3s done
#17 DONE 38.2s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---

running 227 tests
........................................................................................  88/227
........................................................................................ 176/227
.................2024-05-26T22:02:00.610655Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
[crashes] tests/crashes/125432.rs ... F
[crashes] tests/crashes/125432.rs ... F
...2024-05-26T22:02:00.646036Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
[crashes] tests/crashes/125520.rs ... F
[crashes] tests/crashes/125520.rs ... F
.....................2024-05-26T22:02:01.147962Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
[crashes] tests/crashes/125370.rs ... F
.......

failures:
failures:

---- [crashes] tests/crashes/125432.rs stdout ----

error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125432.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- [crashes] tests/crashes/125520.rs stdout ----


error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125520.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:

---- [crashes] tests/crashes/125370.rs stdout ----


error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125370.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:


failures:
    [crashes] tests/crashes/125432.rs

rust-log-analyzer · 2024-05-26T22:10:06Z

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [crashes] tests/crashes/125185.rs ... ok
test [crashes] tests/crashes/125081.rs ... ok
test [crashes] tests/crashes/125099.rs ... ok
test [crashes] tests/crashes/125249.rs ... ok
2024-05-26T22:06:04.867957Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
test [crashes] tests/crashes/125476.rs ... ok
test [crashes] tests/crashes/125512.rs ... ok
test [crashes] tests/crashes/125512.rs ... ok
2024-05-26T22:06:04.923766Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
test [crashes] tests/crashes/34127.rs ... ok
test [crashes] tests/crashes/54888.rs ... ok
test [crashes] tests/crashes/57276.rs ... ok
test [crashes] tests/crashes/74299.rs ... ok
---
test [crashes] tests/crashes/93182.rs ... ok
test [crashes] tests/crashes/93237.rs ... ok
test [crashes] tests/crashes/94846.rs ... ok
test [crashes] tests/crashes/125323.rs ... ok
2024-05-26T22:06:05.519392Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
test [crashes] tests/crashes/96304.rs ... ok
test [crashes] tests/crashes/98322.rs ... ok
test [crashes] tests/crashes/97501.rs ... ok
test [crashes] tests/crashes/92004.rs ... ok
---
failures:

---- [crashes] tests/crashes/125432.rs stdout ----

error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125432.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: <compiletest::runtest::TestCx>::fatal
   2: <compiletest::runtest::TestCx>::fatal
   3: <compiletest::runtest::TestCx>::run_revision
   4: compiletest::runtest::run
   5: <compiletest::make_test_closure::{closure#0} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

---- [crashes] tests/crashes/125520.rs stdout ----

error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125520.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: <compiletest::runtest::TestCx>::fatal
   2: <compiletest::runtest::TestCx>::fatal
   3: <compiletest::runtest::TestCx>::run_revision
   4: compiletest::runtest::run
   5: <compiletest::make_test_closure::{closure#0} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

---- [crashes] tests/crashes/125370.rs stdout ----

error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125370.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: <compiletest::runtest::TestCx>::fatal

jieyouxu · 2024-05-26T22:14:36Z

tests/crashes/125432.rs looks like fixed by #125466, not sure about the other ones

bjorn3 and others added 21 commits May 13, 2024 14:34

Only allow immutable statics with #[linkage]

531dae1

Don't continue probing for method if in suggestion and autoderef hits…

4bc41b9

… ambiguity

Don't skip inner const when looking for body for suggestion

c58b7c9

cleanup dependence of ExtCtxt in transcribe when macro expansion

2782123

Remove deprecated field dist.missing-tools

56dddd4

It's been 5 months since this field was deprecated. Signed-off-by: onur-ozkan <work@onurozkan.dev>

add change entry

c76477d

Signed-off-by: onur-ozkan <work@onurozkan.dev>

crashes: increment the number of tracked ones

ce67768

Also mention my-self for check-cfg docs changes

bebcb4e

Simplify the unchecked_sh[lr] ub-checks a bit

0c84361

Notify T-rustdoc for beta-accepted and stable-accepted too

91b3ef5

Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed.

Avoid a FieldIdx::from_usize in InstSimplify

d37f456

Rollup merge of rust-lang#125046 - bjorn3:no_mutable_static_linkage, …

a843f3d

…r=cjgillot Only allow immutable statics with #[linkage]

Rollup merge of rust-lang#125469 - compiler-errors:dont-skip-inner-co…

5a70821

…nst-body, r=cjgillot Don't skip out of inner const when looking for body for suggestion Self-explanatory title, I'll point out the important logic in an inline comment. Fixes rust-lang#125370

Rollup merge of rust-lang#125535 - onur-ozkan:remove-deprecated-field…

406aadd

…, r=clubby789 clean-up: remove deprecated field `dist.missing-tools` It's been 5 months since this field was deprecated.

Rollup merge of rust-lang#125539 - matthiaskrgr:cräsh, r=jieyouxu

526cefa

crashes: increment the number of tracked ones r? `@jieyouxu`

Rollup merge of rust-lang#125559 - scottmcm:simplify-shift-ubcheck, r…

dbc0037

…=workingjubilee Simplify the `unchecked_sh[lr]` ub-checks a bit It can use the constant in the check, rather than passing it as a parameter.

Rollup merge of rust-lang#125582 - scottmcm:less-from-usize, r=jieyouxu

b2d7f77

Avoid a `FieldIdx::from_usize` in InstSimplify Just a tiny cleanup I noticed in passing while looking at something unrelated.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2024

bors mentioned this pull request May 26, 2024

A small diagnostic improvement for dropping_copy_types #125433

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2024

This was referenced May 26, 2024

Don't continue probing for method if in suggestion and autoderef hits ambiguity #125466

Merged

Rollup of 7 pull requests #125591

Closed

workingjubilee closed this May 26, 2024

workingjubilee deleted the rollup-yr47gxo branch May 26, 2024 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #125588

Rollup of 10 pull requests #125588

workingjubilee commented May 26, 2024

workingjubilee commented May 26, 2024

bors commented May 26, 2024

bors commented May 26, 2024

bors commented May 26, 2024

bors commented May 26, 2024

workingjubilee commented May 26, 2024

bors commented May 26, 2024

rust-log-analyzer commented May 26, 2024

workingjubilee commented May 26, 2024

workingjubilee commented May 26, 2024

bors commented May 26, 2024

rust-log-analyzer commented May 26, 2024

rust-log-analyzer commented May 26, 2024

jieyouxu commented May 26, 2024

Rollup of 10 pull requests #125588

Rollup of 10 pull requests #125588

Conversation

workingjubilee commented May 26, 2024

workingjubilee commented May 26, 2024

bors commented May 26, 2024

bors commented May 26, 2024

bors commented May 26, 2024

bors commented May 26, 2024

workingjubilee commented May 26, 2024

bors commented May 26, 2024

rust-log-analyzer commented May 26, 2024

workingjubilee commented May 26, 2024

workingjubilee commented May 26, 2024

bors commented May 26, 2024

rust-log-analyzer commented May 26, 2024

rust-log-analyzer commented May 26, 2024

jieyouxu commented May 26, 2024