(Big performance change) Do not run lints that cannot emit #125116

blyxyas · 2024-05-14T11:20:44Z

Before this lint, adding a lint was a difficult matter because it always had some overhead involved. This was because all lints would run, no matter their default level, or if the user had #![allow]ed them. This PR changes that. This change would improve both the Rust lint infrastructure and Clippy, but Clippy will see the most benefit, as it has about 900 registered lints (and growing!)

So yeah, with this little patch we filter all lints pre-linting, and remove any lint that is either:

Manually #![allow]ed in the whole crate,
Allowed in the command line, or
Not manually enabled with #[warn] or similar, and its default level is Allow

As some lints need to run, this PR also adds loadbearing lints. On a lint declaration, you can use the [loadbearing: true] marker to label it as loadbearing. A loadbearing lint will never be filtered.

Phase 1/2 Not all lints are being filtered, I'm still working on it, but this branch still gives us about a 2% improvement, so why not merge it already.

Fixes #106983

rustbot · 2024-05-14T11:20:52Z

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-05-14T11:20:54Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

blyxyas · 2024-05-14T11:22:05Z

cc @nnethercote @Kobzol, the perf wizards. Could you please give this PR a look and tell me if there are any obvious performance issues on the filtering?

matthiaskrgr · 2024-05-14T11:26:37Z

@bors try @rust-timer queue

…r=<try> (Big performance change) Do not run lints that cannot emit Before this lint, adding a lint was a difficult matter because it always had some overhead involved. This was because all lints would run, no matter their default level, or if the user had `#![allow]`ed them. This PR changes that. This change would improve both the Rust lint infrastructure and Clippy, but Clippy will see the most benefit, as it has about 900 registered lints (and growing!) So yeah, with this little patch we filter all lints pre-linting, and remove any lint that is either: - Manually `#![allow]`ed in the whole crate, - Allowed in the command line, or - Not manually enabled with `#[warn]` or similar, and its default level is `Allow` I open this PR to receive some feedback, mainly related to performance. We have lots of `Lock`s, `with_lock` and similar functions (also lots of cloning), so the filtering performance is not the best. In an older iteration, instead of doing this in the parsing phase, we developed a visitor with the same function but without so many locks, would reverting to that change help? I'm not sure tbh.

bors · 2024-05-14T11:27:49Z

⌛ Trying commit 7606f89 with merge cc1d40f...

Kobzol · 2024-05-14T11:54:10Z

@lqd haven't you tried something like this before? 🤔

bors · 2024-05-14T13:04:11Z

☀️ Try build successful - checks-actions
Build commit: cc1d40f (cc1d40f134ee8336cbb7c7561deaed4aa5906e0e)

lqd · 2024-05-14T13:14:38Z

@lqd haven't you tried something like this before? 🤔

We've tried a few different things yes, and so has blyxyas -- it maybe wasn't exactly like this, but I encountered annoyances like: some slow const eval loadbearing lint that shouldn't be ignored, lints that would be allowed unexpectedly because cargo allows lints unconditionally on dependencies (arguably the most common usage, and where perf gains would show up AFAICT) but some may trigger FCWs or are required to lint on dependencies despite being allowed, et cetera.

Refactoring and fixing all these were too costly compared to the gains at the time, as rustc's lints were fast enough on dependencies, also a "rarer" use-case. That being said, we've added and uplifted more lints since then, including possibly costly ones like the non local impls one, and the situation may also be different for clippy itself (but we won't see that in the perf.rlo results, only locally with the clippy dedicated commands IIUC)

rust-timer · 2024-05-14T14:45:34Z

Finished benchmarking commit (cc1d40f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	25
Regressions ❌ (secondary)	0.4%	[0.1%, 1.6%]	11
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	0.3%	[-0.4%, 0.5%]	26

Max RSS (memory usage)

Results (primary 2.3%, secondary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	3.6%	[2.0%, 5.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.7%	[-5.2%, -4.1%]	2
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Cycles

Results (secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[1.5%, 3.1%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.788s -> 676.098s (-0.10%)
Artifact size: 316.11 MiB -> 316.15 MiB (0.01%)

Centri3 · 2024-05-14T14:54:05Z

The benchmark doesn't check clippy, right? As lqd hinted at as well? And without splitting allow-by-default rustc lints it does nothing without clippy, so I think this just shows how much time it takes to filter them (can someone else confirm this :3c)

Thus, basically nothing it seems :3 (So @blyxyas maybe the cloning is ok?)

blyxyas · 2024-05-15T08:51:10Z

The benchmark doesn't check clippy, right?

Yeah, the benchmarks currently doesn't check Clippy, that's why I'm currently benchmarking on a different server via SSH (A server that we got explicitly to benchmark Clippy). I'll post the results here when they arrive :)

Also, it currently doesn't check builtin lints because I'm having some issues checking that. That's also part of why I decided to open the PR, maybe someone has some idea (I'll see if I can read the previous attempts by lqd, maybe I can learn something from them)

EDIT: Seems like lqd hasn't pushed their attempts, I'll have to keep trying new approaches by myself.

blyxyas · 2024-05-15T11:04:14Z

Okis, here are the results (Wall time, Clippy)

Wall time

❌
[ +0.45%, +190.50%]
+9.60% 81 (36)
✅
[-73.80%, -0.44%]
-7.00% 77 (36)
❌,✅
[-73.80%, +190.50%]
+1.51% 158 (44)

Max RSS

❌
[ +0.40%, +2.80%]
+1.17% 21 (16)
✅
[ -5.15%, -0.44%]
-1.60% 39 (24)
❌,✅
[ -5.15%, +2.80%]
-0.63% 60 (31)

Instructions

❌
[ +0.42%, +0.62%]
+0.52% 6 (4)
✅
[ -1.82%, -0.32%]
-0.74% 13 (7)
❌,✅
[ -1.82%, +0.62%]
-0.34% 19 (11)

Cycles

[ +0.42%, +25.48%]
+4.33% 91 (38)
✅
[-14.52%, -0.40%]
-3.33% 59 (32)
❌,✅
[-14.52%, +25.48%]
+1.31% 150 (43)

blyxyas · 2024-05-15T11:06:43Z

Those wall times are proof that this optimization has a lot of potential, the main drawback is that the filtering / parsing code is not fast enough, so in some scenarios that I'm not really able to determine exactly what do they have in common, the optimization goes backwards.

But a ~70% in Wall time, that's great and we should look more into it.

Kobzol · 2024-05-15T11:09:50Z

I wouldn't draw too many conclusions from these results, they seem to be quite unstable (there is also a 190% walltime regression). Note that even for PRs that don't have large perf. impacts, we can see ~30% walltime swings even on the stable benchmarking server (https://perf.rust-lang.org/compare.html?start=9e7aff794539aa040362f4424eb29207449ffce0&end=44fa5fd39a1d2af41bd7f43bc246a5e4f6d94696&stat=wall-time&nonRelevant=true).

blyxyas · 2024-05-15T17:13:50Z

I've changed the system, we're back to using visitors (I've benchmarked this new commit, it should have 0 regressions and about -0.66% improvement)

@bors try @rust-timer queue

bors · 2024-05-15T17:15:02Z

⌛ Trying commit 828cd60 with merge 68a9e31...

rust-timer · 2024-09-03T17:14:50Z

Finished benchmarking commit (50e9dfe): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.3%, 4.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.76s -> 750.368s (-0.05%)
Artifact size: 338.30 MiB -> 338.38 MiB (0.02%)

blyxyas · 2024-09-07T13:20:29Z

I've done some benchmarks on the new commit on Clippy on server

Summary

	Range	Mean	Count
Regressions	0.30%, 6.38%	0.84%	23
Improvements	-4.89%, -0.30%	-1.36%	89
All	-4.89%, 6.38%	-0.91%	112

Primary benchmarks

Benchmark	Profile	Scenario	% Change	Significance Factor
webrender-2022	clippy	incr-full	-4.66%	23.28x
webrender-2022	clippy	full	-4.19%	20.97x
ripgrep-13.0.0	clippy	incr-unchanged	-3.64%	18.21x
ripgrep-13.0.0	clippy	incr-patched: println	-3.48%	17.38x
regex-1.5.5	clippy	incr-patched: Job	-2.92%	14.59x
unicode-normalization-0.1.19	clippy	incr-full	-2.89%	14.46x
syn-1.0.89	clippy	full	-2.59%	12.94x
clap-3.1.6	clippy	full	-2.54%	12.68x
syn-1.0.89	clippy	incr-full	-2.52%	12.62x
unicode-normalization-0.1.19	clippy	incr-patched: println	-2.44%	12.18x
clap-3.1.6	clippy	incr-full	-2.40%	11.98x
cargo-0.60.0	clippy	incr-full	-2.33%	11.65x
unicode-normalization-0.1.19	clippy	incr-unchanged	-2.24%	11.18x
cargo-0.60.0	clippy	full	-2.23%	11.14x
unicode-normalization-0.1.19	clippy	full	-2.03%	10.13x
ripgrep-13.0.0	clippy	full	-1.97%	9.83x
serde_derive-1.0.136	clippy	full	-1.94%	9.69x
ripgrep-13.0.0	clippy	incr-full	-1.93%	9.63x
regex-1.5.5	clippy	incr-full	-1.91%	9.54x
serde_derive-1.0.136	clippy	incr-full	-1.91%	9.53x
diesel-1.4.8	clippy	incr-patched: println	-1.81%	9.07x
cranelift-codegen-0.82.1	clippy	incr-full	-1.74%	8.68x
cranelift-codegen-0.82.1	clippy	full	-1.55%	7.73x
diesel-1.4.8	clippy	incr-unchanged	-1.50%	7.49x
exa-0.10.1	clippy	full	-1.40%	6.99x
exa-0.10.1	clippy	incr-full	-1.36%	6.80x
hyper-0.14.18	clippy	full	-1.25%	6.24x
regex-1.5.5	clippy	full	-1.23%	6.14x
diesel-1.4.8	clippy	full	-1.19%	5.93x
diesel-1.4.8	clippy	incr-full	-1.18%	5.89x
image-0.24.1	clippy	incr-full	-1.16%	5.79x
html5ever-0.26.0	clippy	full	-1.13%	5.65x
hyper-0.14.18	clippy	incr-unchanged	1.09%	5.43x
bitmaps-3.1.0	clippy	incr-full	-1.05%	5.27x
cargo-0.60.0	clippy	incr-patched: println	-1.01%	5.03x
image-0.24.1	clippy	full	-0.98%	4.90x
cranelift-codegen-0.82.1	clippy	incr-patched: println	-0.98%	4.90x
regex-1.5.5	clippy	incr-patched: is valid cap letter	-0.92%	4.58x
bitmaps-3.1.0	clippy	full	-0.90%	4.49x
exa-0.10.1	clippy	incr-patched: printlns	-0.88%	4.39x
html5ever-0.26.0	clippy	incr-full	-0.78%	3.89x
image-0.24.1	clippy	incr-patched: println	-0.75%	3.73x
stm32f4-0.14.0	clippy	incr-patched: negate	-0.64%	3.20x
webrender-2022	clippy	incr-patched: println	-0.62%	3.08x
clap-3.1.6	clippy	incr-patched: println	-0.61%	3.07x
regex-1.5.5	clippy	incr-patched: byte frequencies	0.59%	2.93x
helloworld	clippy	incr-unchanged	0.55%	2.74x
bitmaps-3.1.0	clippy	incr-patched: println	0.53%	2.64x
cargo-0.60.0	clippy	incr-unchanged	-0.50%	2.51x
helloworld	clippy	incr-patched: println	0.47%	2.34x
typenum-1.17.0	clippy	incr-patched: add fn	-0.44%	2.18x
helloworld	clippy	incr-full	0.41%	2.03x
serde-1.0.136	clippy	incr-patched: println	-0.39%	1.96x
serde-1.0.136	clippy	incr-unchanged	-0.39%	1.95x
libc-0.2.124	clippy	incr-full	-0.36%	1.78x
syn-1.0.89	clippy	incr-patched: println	-0.35%	1.76x
regex-1.5.5	clippy	incr-patched: compile one	-0.35%	1.74x
libc-0.2.124	clippy	incr-patched: clone	-0.34%	1.68x
serde-1.0.136	clippy	full	-0.32%	1.61x
exa-0.10.1	clippy	incr-unchanged	-0.30%	1.52x
hyper-0.14.18	clippy	incr-patched: println	0.30%	1.51x

Secondary benchmarks

Benchmark	Profile	Scenario	% Change	Significance Factor
deep-vector	clippy	full	6.38%	31.92x
regression-31157	clippy	full	-4.89%	24.47x
regression-31157	clippy	incr-full	-4.75%	23.74x
unused-warnings	clippy	incr-full	-1.94%	9.72x
wg-grammar	clippy	full	-1.76%	8.79x
ripgrep-13.0.0-tiny	clippy	full	-1.74%	8.70x
tuple-stress	clippy	incr-unchanged	-1.60%	7.99x
ucd	clippy	incr-unchanged	-1.51%	7.54x
wg-grammar	clippy	incr-full	-1.47%	7.33x
issue-46449	clippy	incr-unchanged	1.29%	6.43x
coercions	clippy	incr-full	-1.28%	6.38x
unused-warnings	clippy	full	-1.23%	6.13x
deeply-nested-multi	clippy	incr-full	-1.17%	5.86x
deeply-nested-multi	clippy	full	-1.17%	5.84x
issue-46449	clippy	incr-full	0.97%	4.87x
regression-31157	clippy	incr-patched: println	-0.94%	4.72x
tt-muncher	clippy	incr-unchanged	0.89%	4.45x
coercions	clippy	incr-unchanged	-0.86%	4.30x
ctfe-stress-5	clippy	incr-full	-0.81%	4.05x
coercions	clippy	full	-0.78%	3.88x
unused-warnings	clippy	incr-patched: dummy fn	-0.74%	3.68x
regression-31157	clippy	incr-unchanged	-0.73%	3.65x
unused-warnings	clippy	incr-unchanged	0.71%	3.54x
tt-muncher	clippy	full	0.67%	3.36x
externs	clippy	incr-full	-0.67%	3.35x
wf-projection-stress-65510	clippy	incr-unchanged	0.63%	3.17x
match-stress	clippy	incr-unchanged	-0.63%	3.15x
issue-88862	clippy	full	-0.60%	2.99x
unify-linearly	clippy	incr-patched: dummy fn	-0.59%	2.94x
many-assoc-items	clippy	incr-full	-0.58%	2.88x
ctfe-stress-5	clippy	full	-0.56%	2.78x
tuple-stress	clippy	incr-full	-0.55%	2.76x
issue-46449	clippy	incr-patched: empty 3072	0.55%	2.75x
ucd	clippy	incr-full	-0.55%	2.73x
deeply-nested-multi	clippy	incr-unchanged	-0.54%	2.71x
tuple-stress	clippy	incr-patched: new row	-0.54%	2.69x
issue-88862	clippy	incr-full	-0.53%	2.64x
many-assoc-items	clippy	incr-unchanged	-0.51%	2.56x
helloworld-tiny	clippy	full	0.48%	2.42x
coercions	clippy	incr-patched: add static arr item	-0.47%	2.37x
issue-46449	clippy	incr-patched: io error 6144	0.46%	2.29x
unify-linearly	clippy	incr-unchanged	0.44%	2.20x
issue-46449	clippy	incr-patched: u32 3072	0.41%	2.06x
many-assoc-items	clippy	full	-0.40%	1.99x
issue-46449	clippy	incr-patched: u8 3072	0.39%	1.95x
ucd	clippy	full	-0.38%	1.90x
externs	clippy	incr-unchanged	0.37%	1.85x
tt-muncher	clippy	incr-full	0.35%	1.77x
issue-46449	clippy	incr-patched: static str 6144	0.34%	1.72x
derive	clippy	incr-full	-0.32%	1.61x
tuple-stress	clippy	full	-0.32%	1.59x

Polish marramiau miau miau 🎉 meowmeowmeow Removing unused files Meow format Make lint level minimums parallel Fix author lint + stop using symbols Move from symbols to strings + fix things meow sync Remove crate-checking code Prepare for WIP PR opening m Turn back to visitor Add loadbearing lints + Move filtering code to lint_crate Move lint filter to check_mod Also handle lint groups + Should work

blyxyas · 2024-09-11T17:46:42Z

I've done some more benchmarking, we have some very good numbers. I think this is ready to start looking into merging
I'm not sure why the artifacts size has changed, only lints should have been impacted.

michaelwoerister · 2024-09-12T08:49:55Z

The code still contains sections of commented out code and has some unaddressed review comments. Would you mind doing a clean up pass over everything?

blyxyas · 2024-09-21T14:32:50Z

@rustbot ready

cjgillot

Why all the clippy test changes?
Could you squash the commits, or splitting the history in 2 or 3 self-contained commits?

cjgillot · 2024-09-22T17:24:55Z

compiler/rustc_lint/src/builtin.rs

@@ -20,6 +20,7 @@
 //! If you define a new `LateLintPass`, you will also need to add it to the
 //! `late_lint_methods!` invocation in `lib.rs`.

+use std::default::Default;


Isn't this in prelude?

cjgillot · 2024-09-22T17:25:04Z

compiler/rustc_lint/src/builtin.rs

+// use std::fmt::Write;
+
+// hardwired lints from rustc_lint_defs
+// pub use rustc_session::lint::builtin::*;


Commented-out code.

cjgillot · 2024-09-22T17:25:32Z

compiler/rustc_lint/src/internal.rs

@@ -439,7 +439,8 @@ declare_tool_lint! {
    pub rustc::UNTRANSLATABLE_DIAGNOSTIC,
    Deny,
    "prevent creation of diagnostics which cannot be translated",
-    report_in_external_macro: true
+    report_in_external_macro: true,
+    [eval_always: true]


Could the syntax be closer to other modifiers?

cjgillot · 2024-09-22T17:25:51Z

compiler/rustc_lint/src/late.rs

-        let mut passes: Vec<_> = late_module_passes.iter().map(|mk_pass| (mk_pass)(tcx)).collect();
-        passes.push(Box::new(builtin_lints));
-        let pass = RuntimeCombinedLateLintPass { passes: &mut passes[..] };
+        let chained_box = Box::new(builtin_lints) as Box<dyn LateLintPass<'tcx>>;


Suggested change

let chained_box = Box::new(builtin_lints) as Box<dyn LateLintPass<'tcx>>;

let builtin_lints = Box::new(builtin_lints) as Box<dyn LateLintPass<'tcx>>;

?

cjgillot · 2024-09-22T17:26:16Z

compiler/rustc_lint/src/late.rs

+    //         .any(|lint|
+    //             !lints_that_dont_need_to_run.contains(&LintId::of(lint)))
+    // }).collect();
+    //


Commented-out code.

cjgillot · 2024-09-22T17:28:26Z

compiler/rustc_lint/src/passes.rs

@@ -218,7 +221,7 @@ macro_rules! declare_combined_early_lint_pass {

            $v fn get_lints() -> $crate::LintVec {
                let mut lints = Vec::new();
-                $(lints.extend_from_slice(&$pass::get_lints());)*
+                $(lints.extend_from_slice(&$pass::default().get_lints());)*


Suggested change

$(lints.extend_from_slice(&$pass::default().get_lints());)*

$(lints.extend_from_slice(&$pass::get_lints());)*

cjgillot · 2024-09-22T17:28:58Z

compiler/rustc_lint_defs/src/lib.rs

-        }
-        impl $ty {
-            pub fn get_lints() -> $crate::LintVec { vec![$($lint),*] }
+            fn get_lints(&self) -> $crate::LintVec { vec![$($lint),*] }
        }


Still relevant.

cjgillot · 2024-09-22T17:29:05Z

compiler/rustc_lint_defs/src/lib.rs

+    fn get_lints(&self) -> LintVec {
+        (**self).get_lints()
+    }
+}


Still relevant.

cjgillot · 2024-09-22T17:29:51Z

src/tools/clippy/clippy_lints/src/cognitive_complexity.rs

+You'll see it when you get the warning.",
+    version: Some("1.35.0"),
+    location: "clippy_lints/src/cognitive_complexity.rs#L47",
+};


Why is this needed?

cjgillot · 2024-09-22T17:31:21Z

src/tools/clippy/clippy_lints/src/ctfe.rs

+use rustc_span::Span;
+
+/// Ensures that Constant-time Function Evaluation is being done (specifically, MIR lint passes).
+/// See rust-lang/rust#125116 for more info.


There are >100 comments in the PR. Could you summarize the question here?

rustbot assigned michaelwoerister May 14, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 14, 2024

blyxyas marked this pull request as draft May 14, 2024 11:23

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 14, 2024

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 14, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2024

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Sep 3, 2024

blyxyas added 13 commits September 7, 2024 15:24

Fix nits from review

cb1688c

name_without_tool Now takes a &str instead of String

5ae3622

Change lints_to_emit to lints_that_actually_run

11e09a3

Fix CI, and use FxIndexSet

04bac39

Follow review comments (optimize the filtering)

dd90950

EVERYTHING GREEN

768e542

tidy

01f6459

Fix tidy

bc41a6b

Rebase and merge

e1af312

Fmt

6ecd060

Remove module passes filtering

5f8fc79

Fix merge conflicts

b5ac9b5

blyxyas force-pushed the ignore-allowed-lints-final branch from 8c1bf71 to b5ac9b5 Compare September 7, 2024 13:34

blyxyas mentioned this pull request Sep 13, 2024

Turn declare_clippy_lint into a declarative macro rust-lang/rust-clippy#13359

Open

Cleanup, handle reviews

bdf21a4

blyxyas force-pushed the ignore-allowed-lints-final branch from 66b4653 to bdf21a4 Compare September 14, 2024 01:15

jieyouxu removed their assignment Sep 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2024

cjgillot reviewed Sep 22, 2024

View reviewed changes

cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2024

	let chained_box = Box::new(builtin_lints) as Box<dyn LateLintPass<'tcx>>;
	let builtin_lints = Box::new(builtin_lints) as Box<dyn LateLintPass<'tcx>>;

	$(lints.extend_from_slice(&$pass::default().get_lints());)*
	$(lints.extend_from_slice(&$pass::get_lints());)*

(Big performance change) Do not run lints that cannot emit #125116

Are you sure you want to change the base?

(Big performance change) Do not run lints that cannot emit #125116

Conversation

blyxyas commented May 14, 2024 • edited Loading

rustbot commented May 14, 2024

rustbot commented May 14, 2024

blyxyas commented May 14, 2024

matthiaskrgr commented May 14, 2024

This comment has been minimized.

bors commented May 14, 2024

This comment has been minimized.

Kobzol commented May 14, 2024

bors commented May 14, 2024

This comment has been minimized.

lqd commented May 14, 2024 • edited Loading

rust-timer commented May 14, 2024

Overall result: ❌ regressions - ACTION NEEDED

Centri3 commented May 14, 2024 • edited Loading

blyxyas commented May 15, 2024 • edited Loading

blyxyas commented May 15, 2024

Wall time

Max RSS

Instructions

Cycles

blyxyas commented May 15, 2024

Kobzol commented May 15, 2024

blyxyas commented May 15, 2024

This comment has been minimized.

bors commented May 15, 2024

rust-timer commented Sep 3, 2024

Overall result: ❌ regressions - no action needed

blyxyas commented Sep 7, 2024 • edited Loading

Summary

Primary benchmarks

Secondary benchmarks

blyxyas commented Sep 11, 2024 • edited Loading

michaelwoerister commented Sep 12, 2024

blyxyas commented Sep 21, 2024

cjgillot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blyxyas commented May 14, 2024 •

edited

Loading

lqd commented May 14, 2024 •

edited

Loading

Centri3 commented May 14, 2024 •

edited

Loading

blyxyas commented May 15, 2024 •

edited

Loading

blyxyas commented Sep 7, 2024 •

edited

Loading

blyxyas commented Sep 11, 2024 •

edited

Loading