Allow fmt to run on rmake.rs test files

[GuillaumeGomez]

As discussed with @jieyouxu, rmake.rs from the run-make testsuite would benefit from being formatted as well.

Only thing needed to be done for it to work: allow support for ! in our rustfmt.toml file parsing.

r? @onur-ozkan

[rustbot]

Some changes occurred in run-make tests.

cc @jieyouxu

[GuillaumeGomez]

It's safe to remove this path since it's not whitelisted, nothing will be done on it apparently.

[Mark-Simulacrum]

What do you mean by whitelisted? Where is that list?

[GuillaumeGomez]

The way we build the "walker" with the ignore crate is a bit strange. From what I understood, if something is not added to the list, it's ignored by default.

In this case for example, I removed the tests folder and added rmake.rs files and only the rmake.rs files have been formatted.

[onur-ozkan]

Could you add an explanation comment (about why we remove "!" when it is present and add it when it is not present) for this block?

[GuillaumeGomez]

Sure!

[GuillaumeGomez]

Added a code comment to explain what's going on. :)

[onur-ozkan]

Thanks!

@bors r+

[bors]

📌 Commit 2134921 has been approved by onur-ozkan

It is now in the queue for this repository.

[fmease]

needs rebase
@bors r-

[GuillaumeGomez]

@bors r=onur-ozkan rollup

[bors]

📌 Commit 8f47f97 has been approved by onur-ozkan

It is now in the queue for this repository.

[Urgau]

I'm seeing errors when trying to run ./x.py fmt locally after a rebase; I looks like rustfmt is trying to format UI tests.

Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
formatting 68 modified files
error: expected identifier, found reserved keyword `try`
   --> /rust/tests/ui/macros/macro-comma-support-rpass.rs:269:4
    |
269 | fn try() {
    |    ^^^ expected identifier, found reserved keyword
    |
help: escape `try` to use it as an identifier
    |
269 | fn r#try() {
    |    ++

error: use of deprecated `try` macro
   --> /rust/tests/ui/macros/macro-comma-support-rpass.rs:271:9
    |
271 |         try!(Ok(()));
    |         ^^^^^^^^^^^^
    |
    = note: in the 2018 edition `try` is a reserved keyword, and the `try!()` macro is deprecated
help: you can use the `?` operator instead
    |
271 -         try!(Ok(()));
271 +         Ok(())?;
    |
help: alternatively, you can still access the deprecated `try!()` macro using the "raw identifier" syntax
    |
271 |         r#try!(Ok(()));
    |         ++

error: use of deprecated `try` macro
   --> /home/archie/Projects/RustProjects/rust/tests/ui/macros/macro-comma-support-rpass.rs:272:9
    |
272 |         try!(Ok(()),);
    |         ^^^^^^^^^^^^^
    |
    = note: in the 2018 edition `try` is a reserved keyword, and the `try!()` macro is deprecated
help: you can use the `?` operator instead
    |
272 -         try!(Ok(()),);
272 +         Ok(()),?;
    |
help: alternatively, you can still access the deprecated `try!()` macro using the "raw identifier" syntax
    |
272 |         r#try!(Ok(()),);
    |         ++

Running `"/rust/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/rust" "--edition" "2021" "--unstable-features" "--skip-children" "/rust/tests/ui/macros/macro-with-attrs1.rs" "//rust/tests/ui/macros/macro-meta-items.rs" "/rust/tests/ui/macros/macro-comma-support-rpass.rs" "/rust/tests/ui/macros/syntax-extension-cfg.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
Build completed unsuccessfully in 0:00:01

Re-adding /tests/ in the rustfmt.toml file, fixes the build error.

[Urgau]

I posted #124704 to fix the issue.