Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull request template asking for relevant tracking issues #123492

Merged
merged 1 commit into from
May 21, 2024

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Apr 5, 2024

As mentioned at RustNation, I would like to remind PR authors to link to relevant tracking issues when opening PRs as it is otherwise very easy to forget doing so.

There's a certain amount of conflict between making the template as small as possible while still being clear for new contributors. I am very much open to changes here but really want to try this out.

Also unsure how much formal buy-in we need here. Maybe merge this pinging t-compiler and t-libs, and then ask how people feel about this on zulip in a few weeks?

r? @davidtwco

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2024
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wesleywiser in case you have opinions

@@ -0,0 +1,10 @@
related tracking issue:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to say that we should do without this line and just include the comment that might be sufficient to remind people?

Suggested change
related tracking issue:


This automatically references this PR in the tracking issue which makes it far easier
to see the ongoing process on a given issue and also provides a list of the relevant
work when summarizing a feature for stabilization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also remind people that they can use r? here to select a reviewer if there is someone who has been mentoring them or seems appropriate for the work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that, using r<zero-width space>? <reviewer name> in the html comment as otherwise bors ends up confused if people don't remove it

@davidtwco
Copy link
Member

Would appreciate opinions on whether this is desirable, cc @rust-lang/compiler @rust-lang/libs

@michaelwoerister
Copy link
Member

Seems like a good idea to me

@the8472
Copy link
Member

the8472 commented May 10, 2024

Would appreciate opinions on whether this is desirable

Libs also keeps an implementation history list in tracking issues so this SGTM.

@lcnr
Copy link
Contributor Author

lcnr commented May 21, 2024

given the feedback I am going to merge this. we can always revert this if it causes any issues or is annoying. Will open a thread on zulip in a few weeks to get feedback if nothing blew up since then.

@bors r=davidtwco rollup=always

@bors
Copy link
Contributor

bors commented May 21, 2024

📌 Commit 939a711 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#123122 (Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses.)
 - rust-lang#123492 (add pull request template asking for relevant tracking issues)
 - rust-lang#125276 (Fix parsing of erroneously placed semicolons)
 - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs)
 - rust-lang#125357 (Migrate `run-make/rustdoc-scrape-examples-multiple` to `rmake.rs`)
 - rust-lang#125369 (Don't do cc detection for synthetic targets)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a90db7 into rust-lang:master May 21, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2024
Rollup merge of rust-lang#123492 - lcnr:master, r=davidtwco

add pull request template asking for relevant tracking issues

As mentioned at RustNation, I would like to remind PR authors to link to relevant tracking issues when opening PRs as it is otherwise very easy to forget doing so.

There's a certain amount of conflict between making the template as small as possible while still being clear for new contributors. I am very much open to changes here but really want to try this out.

Also unsure how much formal buy-in we need here. Maybe merge this pinging t-compiler and t-libs, and then ask how people feel about this on zulip in a few weeks?

r? `@davidtwco`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants