Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote riscv64gc-unknown-linux-musl to tier 2 #122049

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Promote riscv64gc-unknown-linux-musl to tier 2 #122049

merged 3 commits into from
Aug 6, 2024

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Mar 5, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 5, 2024
@Amanieu
Copy link
Member Author

Amanieu commented Mar 5, 2024

I'm looking for a second target maintainer, this is required for tier 2 support.

cc @kraj @nmeum since you were involved in #82202

@kraj
Copy link
Contributor

kraj commented Mar 5, 2024

I'm looking for a second target maintainer, this is required for tier 2 support.

cc @kraj @nmeum since you were involved in #82202

@Amanieu I will be happy to help. Please add me.

kraj
kraj approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Amanieu
Copy link
Member Author

Amanieu commented Mar 5, 2024

I've opened an MCP: rust-lang/compiler-team#728

@Amanieu Amanieu changed the title Promote riscv64gc-unknown-linux-gnu to tier 2 Promote riscv64gc-unknown-linux-musl to tier 2 Mar 6, 2024
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
@Mark-Simulacrum
Copy link
Member

This should probably update the platform support docs to indicate the tier 2 target.

@bors
Copy link
Contributor

bors commented Mar 12, 2024

☔ The latest upstream changes (presumably #122170) made this pull request unmergeable. Please resolve the merge conflicts.

@kraj
Copy link
Contributor

kraj commented Mar 12, 2024

☔ The latest upstream changes (presumably #122170) made this pull request unmergeable. Please resolve the merge conflicts.

@Amanieu this needs a manual rebase and push I guess

@Dylan-DPC Dylan-DPC added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2024
@Amanieu Amanieu marked this pull request as ready for review June 22, 2024 15:05
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

These commits modify compiler targets.
(See the Target Tier Policy.)

@Amanieu Amanieu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. labels Jul 3, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 4, 2024

📌 Commit 7478987 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 4, 2024
@bors
Auto merge of rust-lang#122049 - Amanieu:riscv64-musl-tier2, r=Mark-S…
68cbdcb 
…imulacrum

Promote riscv64gc-unknown-linux-musl to tier 2
@bors
Copy link
Contributor

bors commented Jul 4, 2024

⌛ Testing commit 7478987 with merge 68cbdcb...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Aug 2, 2024 

error: linking with `/musl-riscv64gc/bin/musl-gcc` failed: exit status: 1
[...]
  = note: /usr/lib/gcc-cross/riscv64-linux-gnu/11/../../../../riscv64-linux-gnu/bin/ld: cannot find libgcc_s.so.1: No such file or directory

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu Amanieu added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 3, 2024
@Amanieu
Copy link
Member Author

Amanieu commented Aug 3, 2024

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Aug 3, 2024

📌 Commit 9963a6c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 3, 2024
@bors
Copy link
Contributor

bors commented Aug 5, 2024

⌛ Testing commit 9963a6c with merge 9ed8bd5...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2024
@bors
Auto merge of rust-lang#122049 - Amanieu:riscv64-musl-tier2, r=Mark-S…
9ed8bd5 
…imulacrum

Promote riscv64gc-unknown-linux-musl to tier 2
@bors
Copy link
Contributor

bors commented Aug 5, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@tgross35
Copy link
Contributor

tgross35 commented Aug 5, 2024

@bors retry

Looks like some kind of networking error

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 5, 2024
@tgross35
Rollup merge of rust-lang#122049 - Amanieu:riscv64-musl-tier2, r=Mark…
cf0989c 
…-Simulacrum

Promote riscv64gc-unknown-linux-musl to tier 2
@tgross35 tgross35 mentioned this pull request Aug 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2024
@bors
Auto merge of rust-lang#128698 - tgross35:rollup-oan6ari, r=tgross35
4c6e809 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#122049 (Promote riscv64gc-unknown-linux-musl to tier 2)
 - rust-lang#125558 (Tweak type inference for `const` operands in inline asm)
 - rust-lang#128638 (run-make: enable msvc for `link-dedup`)
 - rust-lang#128647 (Enable msvc for link-args-order)
 - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`)
 - rust-lang#128656 (Enable msvc for run-make/rust-lld)
 - rust-lang#128688 (custom MIR: add support for tail calls)
 - rust-lang#128691 (Update `compiler-builtins` to 0.1.115)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2024
@bors
Auto merge of rust-lang#128707 - matthiaskrgr:rollup-63klywk, r=matth…
b586701 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#122049 (Promote riscv64gc-unknown-linux-musl to tier 2)
 - rust-lang#128580 (Use `ParamEnv::reveal_all` in CFI)
 - rust-lang#128688 (custom MIR: add support for tail calls)
 - rust-lang#128694 (Normalize when equating `dyn` tails in MIR borrowck)
 - rust-lang#128697 (interpret: move nullary-op evaluation into operator.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8cbf1c1 into rust-lang:master Aug 6, 2024
6 of 7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
@rust-timer
Unrolled build for rust-lang#122049
094cf43 
Rollup merge of rust-lang#122049 - Amanieu:riscv64-musl-tier2, r=Mark-Simulacrum

Promote riscv64gc-unknown-linux-musl to tier 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraj kraj kraj approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Amanieu @rustbot @kraj @Mark-Simulacrum @bors @rust-log-analyzer @tgross35 @jieyouxu @Dylan-DPC