Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent Result<usize, Box<T>> as ScalarPair(i64, ptr) #121668

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Represent Result<usize, Box<T>> as ScalarPair(i64, ptr) #121668

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dabbcb
allow using scalarpair with a common prim of ptr/ptr-sized-int
erikdesjardins Feb 27, 2024
f574c65
simplify common prim computation
erikdesjardins Feb 28, 2024
8e40b17
fix test failure due to differing u64 alignment on different targets
erikdesjardins Feb 28, 2024
5ccada6
make check lines for int/ptr common prim test more permissive
erikdesjardins Mar 7, 2024
9f55200
refine common_prim test
erikdesjardins Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/codegen/common_prim_int_ptr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ pub fn insert_box(x: Box<()>) -> Result<usize, Box<()>> {
// CHECK-LABEL: @extract_int
#[no_mangle]
pub unsafe fn extract_int(x: Result<usize, Box<()>>) -> usize {
// CHECK: start:
// CHECK-NEXT: ptrtoint
// CHECK-NEXT: ret
// CHECK: ptrtoint
x.unwrap_unchecked()
}
scottmcm marked this conversation as resolved.
Show resolved Hide resolved

// CHECK-LABEL: @extract_box
#[no_mangle]
pub unsafe fn extract_box(x: Result<usize, Box<()>>) -> Box<()> {
// CHECK: start:
// CHECK-NEXT: ret ptr
// CHECK-NOT: ptrtoint
// CHECK-NOT: inttoptr
// CHECK-NOT: load
// CHECK-NOT: store
x.unwrap_err_unchecked()
}
scottmcm marked this conversation as resolved.
Show resolved Hide resolved
Loading