Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target: Revert default to the medium code model on LoongArch targets #121291

Merged
merged 1 commit into from
Feb 20, 2024
Merged

target: Revert default to the medium code model on LoongArch targets #121291

merged 1 commit into from
Feb 20, 2024

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Feb 19, 2024

This reverts commit 35dad14.

Fixes #121289

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@heiher
Copy link
Contributor Author

heiher commented Feb 19, 2024

cc @xen0n @xry111

@Noratrieb
Copy link
Member

oh no
@bors r+

@bors
Copy link
Contributor

bors commented Feb 19, 2024

📌 Commit 9c32a7d has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2024
Copy link
Contributor

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that was unfortunate. No problem though, let's try again after having our cross toolchain bumped!

Noratrieb added a commit to Noratrieb/rust that referenced this pull request Feb 20, 2024
…strieb

target: Revert default to the medium code model on LoongArch targets

This reverts commit 35dad14.

Fixes rust-lang#121289
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#121167 (resolve: Scale back unloading of speculatively loaded crates)
 - rust-lang#121196 (Always inline check in `assert_unsafe_precondition` with cfg(debug_assertions))
 - rust-lang#121241 (Implement `NonZero` traits generically.)
 - rust-lang#121278 (Remove the "codegen" profile from bootstrap)
 - rust-lang#121286 (Rename `ConstPropLint` to `KnownPanicsLint`)
 - rust-lang#121291 (target: Revert default to the medium code model on LoongArch targets)
 - rust-lang#121302 (Remove `RefMutL` hack in `proc_macro::bridge`)
 - rust-lang#121318 (Trigger `unsafe_code` lint on invocations of `global_asm`)

Failed merges:

 - rust-lang#121206 (Top level error handling)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5540d81 into rust-lang:master Feb 20, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2024
Rollup merge of rust-lang#121291 - heiher:revert-medium-cmodel, r=Nilstrieb

target: Revert default to the medium code model on LoongArch targets

This reverts commit 35dad14.

Fixes rust-lang#121289
@heiher heiher deleted the revert-medium-cmodel branch February 21, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LoongArch] dead loop after nightly-2024-02-12
6 participants