Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move personality implementation out of PAL #119935

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

joboet
Copy link
Contributor

@joboet joboet commented Jan 13, 2024

The module already follows the new convention described in #117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in #117285.

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2024

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 13, 2024
@joboet
Copy link
Contributor Author

joboet commented Jan 13, 2024

r? @ChrisDenton
(if you have the time)

@rustbot rustbot assigned ChrisDenton and unassigned m-ou-se Jan 13, 2024
@ChrisDenton
Copy link
Member

Looks straight forward enough!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 13, 2024

📌 Commit b8d996c has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119189 (Move section "Installing from Source" to seperate file)
 - rust-lang#119925 (store the segment name when resolution fails)
 - rust-lang#119935 (Move personality implementation out of PAL)
 - rust-lang#119937 (Improve UEFI target docs)
 - rust-lang#119938 (Allow unauthorized users to user the has-merge-commits label)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3a33a4b into rust-lang:master Jan 14, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
Rollup merge of rust-lang#119935 - joboet:move_pal_personality, r=ChrisDenton

Move personality implementation out of PAL

The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.
@joboet joboet deleted the move_pal_personality branch January 14, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants