Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline check_closure, simplify deduce_sig_from_projection #119900

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

compiler-errors
Copy link
Member

Some minor cleanups that I've collected when reimplementing async closure

r? oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 12, 2024

if !is_fn && !is_gen {
debug!("not fn or coroutine");
// For now, we only do signature deduction based off of the `Fn` traits.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect us to extend this to deduce other coroutines' signatures: #109338

Or at least, when we do start doing so, this method should be reworked to be cleaner and more extensible. Right now there's a lot of funky control flow for absolutely no reason 😅

@oli-obk
Copy link
Contributor

oli-obk commented Jan 15, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 15, 2024

📌 Commit 6a63183 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118361 (stabilise bound_map)
 - rust-lang#119816 (Define hidden types in confirmation)
 - rust-lang#119900 (Inline `check_closure`, simplify `deduce_sig_from_projection`)
 - rust-lang#119969 (Simplify `closure_env_ty` and `closure_env_param`)
 - rust-lang#119990 (Add private `NonZero<T>` type alias.)
 - rust-lang#119998 (Update books)
 - rust-lang#120002 (Lint `overlapping_ranges_endpoints` directly instead of collecting into a Vec)
 - rust-lang#120018 (Don't allow `.html` files in `tests/mir-opt/`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f9d1d4 into rust-lang:master Jan 16, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2024
Rollup merge of rust-lang#119900 - compiler-errors:closure-checking, r=oli-obk

Inline `check_closure`, simplify `deduce_sig_from_projection`

Some minor cleanups that I've collected when reimplementing async closure

r? oli-obk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants