Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix again rustc_codegen_gcc tests #118835

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Dec 11, 2023

Similar to #118706

r? @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2023

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@matthiaskrgr
Copy link
Member

@bors r+ rollup
so i can include that in the next rollup 🙃

@bors
Copy link
Contributor

bors commented Dec 11, 2023

📌 Commit b1bfeb1 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 11, 2023
…askrgr

Fix again `rustc_codegen_gcc` tests

Similar to rust-lang#118706

r? `@GuillaumeGomez`
@GuillaumeGomez
Copy link
Member

It's really strange that they only appear afterward.

@Urgau
Copy link
Member Author

Urgau commented Dec 11, 2023

It's really strange that they only appear afterward.

I think this is due to ENABLE_GCC_CODEGEN: "1" being only defined in the PR jobs and not in the bors jobs.

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#118647 (dump bootstrap shims)
 - rust-lang#118708 (tests: add sanity-check assembly test for every target)
 - rust-lang#118818 (llvm-wrapper: adapt for LLVM API change)
 - rust-lang#118826 (Edit target doc template to remove email)
 - rust-lang#118827 (Update table for linker-plugin-lto docs)
 - rust-lang#118835 (Fix again `rustc_codegen_gcc` tests)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118620 (resolve: Use `def_kind` query to cleanup some code)
 - rust-lang#118647 (dump bootstrap shims)
 - rust-lang#118726 (Do not parenthesize exterior struct lit inside match guards)
 - rust-lang#118818 (llvm-wrapper: adapt for LLVM API change)
 - rust-lang#118822 (Extract exhaustiveness into its own crate)
 - rust-lang#118826 (Edit target doc template to remove email)
 - rust-lang#118827 (Update table for linker-plugin-lto docs)
 - rust-lang#118835 (Fix again `rustc_codegen_gcc` tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1cf538b into rust-lang:master Dec 11, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2023
Rollup merge of rust-lang#118835 - Urgau:fix-rccg-gcc-tests, r=matthiaskrgr

Fix again `rustc_codegen_gcc` tests

Similar to rust-lang#118706

r? `@GuillaumeGomez`
@rustbot rustbot added this to the 1.76.0 milestone Dec 11, 2023
@Urgau Urgau deleted the fix-rccg-gcc-tests branch December 11, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants