Rollup of 5 pull requests #118787

GuillaumeGomez · 2023-12-09T17:00:38Z

Successful merges:

add safe compilation options #117966 (add safe compilation options)
Remove extra check cfg handled by libc directly #118747 (Remove extra check cfg handled by libc directly)
add test for inductive cycle hangs #118774 (add test for inductive cycle hangs)
chore: add test case for type with generic #118775 (chore: add test case for type with generic)
use & instead of start-process in x.ps1 #118782 (use & instead of start-process in x.ps1)

r? @ghost
@rustbot modify labels: rollup

Add two options when building rust: strip and stack protector. If set `strip = true`, symbols will be stripped using `-Cstrip=symbols`. Also can set `stack-protector` and stack protectors will be used.

start-process has weird parsing rules and buggy behavior. we've already had to work around them several times, and the workarounds were not complete. i wonder who could have added it HMMMMMM ``` PS C:\Users\jyn\src\rust> git log --reverse -S Start-Process x.ps1 commit 775c3c0 Author: Jynn Nelson <github@jyn.dev> Date: Sun Jul 31 14:02:31 2022 -0500 Add `x.sh` and `x.ps1` shell scripts ``` the latest broken thing is trailing backslashes: ``` $ x.ps1 t .\tests\ui\error-emitter\ ``` would be transformed into ``` ['t', '.\\tests\\ui\\error-emitter"'] ``` rather than trying to hack around that too, abandon start-process altogether and just use `&`.

…ns, r=Mark-Simulacrum add safe compilation options Add two options when building rustc : strip and stack protector. If set `strip = true`, `rustc` will be stripped of symbols using `-Cstrip=symbols`. Also can set `stack-protector` and then `rustc` will be compiled with stack protectors.

…=onur-ozkan Remove extra check cfg handled by libc directly The `libc` crate has handle for quite some time now [check-cfg in it's own build script](https://github.com/rust-lang/libc/blob/497ac428bc010b5db9682ecf94cd567b31d53e5c/build.rs#L6-L32). We therefor no longer need to manually define them.

…er-errors add test for inductive cycle hangs the same pattern is already tested for coinductive cycles, but I now understand the underlying issue and want to make sure we also test it for inductive ones r? `@compiler-errors`

chore: add test case for type with generic follow up rust-lang#118502

use `&` instead of start-process in x.ps1 start-process has weird parsing rules and buggy behavior. we've already had to work around them several times, and the workarounds were not complete. i wonder who could have added it HMMMMMM ``` PS C:\Users\jyn\src\rust> git log --reverse -S Start-Process x.ps1 commit 775c3c0 Author: Jynn Nelson <github@jyn.dev> Date: Sun Jul 31 14:02:31 2022 -0500 Add `x.sh` and `x.ps1` shell scripts ``` the latest broken thing is trailing backslashes: ``` $ x.ps1 t .\tests\ui\error-emitter\ ``` would be transformed into ``` ['t', '.\\tests\\ui\\error-emitter"'] ``` rather than trying to hack around that too, abandon start-process altogether and just use `&`. r? `@ChrisDenton`

GuillaumeGomez · 2023-12-09T17:00:47Z

@bors r+ p=5 rollup=never

bors · 2023-12-09T17:00:49Z

📌 Commit dd23469 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2023-12-09T18:58:06Z

⌛ Testing commit dd23469 with merge e845469...

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#117966 (add safe compilation options) - rust-lang#118747 (Remove extra check cfg handled by libc directly) - rust-lang#118774 (add test for inductive cycle hangs) - rust-lang#118775 (chore: add test case for type with generic) - rust-lang#118782 (use `&` instead of start-process in x.ps1) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2023-12-09T19:01:27Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2023-12-09T19:01:56Z

💔 Test failed - checks-actions

GuillaumeGomez · 2023-12-09T23:17:43Z

@bors retry

bors · 2023-12-10T01:02:46Z

⌛ Testing commit dd23469 with merge f7253f2...

bors · 2023-12-10T02:59:51Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing f7253f2 to master...

rust-timer · 2023-12-10T03:01:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#117966	add safe compilation options	`2efa93047d79f37c38fba50543338a04ae045462` (link)
#118747	Remove extra check cfg handled by libc directly	`f430421a4a73bbb33656d5a645ea3ea4b8849f04` (link)
#118774	add test for inductive cycle hangs	`74c91cd3c7989183d1d66484d21664247e9f832f` (link)
#118775	chore: add test case for type with generic	`12cb236e6732ebbb6f8e2b39c2ed6083420b58ee` (link)
#118782	use `&` instead of start-process in x.ps1	`29f876e65e181d1dd441226dec83bb17aab54e83` (link)

previous master: 8cd8d31369

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-12-10T04:21:12Z

Finished benchmarking commit (f7253f2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.296s -> 669.693s (0.21%)
Artifact size: 314.15 MiB -> 314.16 MiB (0.00%)

Update Rust toolchain from nightly-2023-12-10 to nightly-2023-12-11 without any other source changes. This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang@06e02d5 up to rust-lang@d86d65b. The log for this commit range is: rust-lang@d86d65bbc1 Auto merge of rust-lang#118368 - GuillaumeGomez:env-flag, r=Nilstrieb rust-lang@ec4176167b Auto merge of rust-lang#118703 - Kobzol:bootstrap-config-unused, r=onur-ozkan rust-lang@f1c5558edc Add ChangeInfo record rust-lang@ccbd88dc83 Remove unused run_dsymutil and gpg_password_file config values rust-lang@6badc0d840 Destructure TOML configs rust-lang@7e452c123c Auto merge of rust-lang#118791 - saethlin:use-immediate-type, r=nikic rust-lang@b9068315db Auto merge of rust-lang#116952 - compiler-errors:lifetime_capture_rules_2024, r=TaKO8Ki rust-lang@befd1eb4ec Auto merge of rust-lang#116278 - Kobzol:bootstrap-lld-mode, r=albertlarsan68,petrochenkov rust-lang@dc2f77aad6 Add (unstable) documentation for `--env` command line option rust-lang@d2b1f94f05 Add feature gate test for `--env` flag rust-lang@37d68093da Add ui tests for `--env` option rust-lang@486e55e547 Implement `--env` compiler flag rust-lang@53031b264e Review fixes rust-lang@84f6130fe3 Auto merge of rust-lang#118692 - surechen:remove_unused_imports, r=petrochenkov rust-lang@4750e9de47 Produce an explicit error when using a self-contained lld, but we don't add it to sysroot rust-lang@ea769dbeb7 Add change tracker entry rust-lang@cbfe6327a1 Do not invoke external lld to figure out thread flags in self-contained mode rust-lang@50865745e1 Update `config.example.toml` rust-lang@40c3d351ad Use MCP510 rust-lang@48c1607bc6 Introduce `LldMode` and generalize parsing of `use-lld` rust-lang@d9f9e67bc1 Refactor rust(do)c linker flags rust-lang@b3c9ffdc77 Add `is_msvc` function rust-lang@c1a3919378 Auto merge of rust-lang#118792 - naglis:fix-mutex-doc-typo, r=workingjubilee rust-lang@42dfac5e08 Auto merge of rust-lang#118788 - compiler-errors:const-pretty, r=fee1-dead rust-lang@61afc9c928 Auto merge of rust-lang#116949 - hamza1311:stablize-arc_unwrap_or_clone, r=dtolnay rust-lang@c71c246876 Auto merge of rust-lang#118550 - cjgillot:filecheck-const-prop, r=Mark-Simulacrum rust-lang@40ae34194c remove redundant imports rust-lang@f7253f2317 Auto merge of rust-lang#118787 - GuillaumeGomez:rollup-fj5wr3q, r=GuillaumeGomez rust-lang@7d50a39763 Fix typo in `std::sync::Mutex` example rust-lang@8cd8d31369 Auto merge of rust-lang#118069 - onur-ozkan:bypass_bootstrap_lock, r=Mark-Simulacrum rust-lang@b0a580112b Use immediate_backend_type when reading from a const alloc rust-lang@afa35e90ef Print constness in TraitPredPrintModifiersAndPath rust-lang@7467c3a45c s/const_effect/host_effect rust-lang@f1bf874fb1 Don't print host effect param in pretty path_generic_args rust-lang@6860654d82 allow bypassing the build directory lock rust-lang@dd234696ed Rollup merge of rust-lang#118782 - jyn514:powershell, r=ChrisDenton rust-lang@034d73d6d7 Rollup merge of rust-lang#118775 - Young-Flash:fix, r=compiler-errors rust-lang@5b9e917b64 Rollup merge of rust-lang#118774 - lcnr:region-refactor-uwu, r=compiler-errors rust-lang@cc821d3ae6 Rollup merge of rust-lang#118747 - Urgau:check-cfg-freebsd-cleanup, r=onur-ozkan rust-lang@83e814f88c Rollup merge of rust-lang#117966 - lxy19980601:safe_compilation_options, r=Mark-Simulacrum rust-lang@2cf54e9f99 use `&` instead of start-process in x.ps1 rust-lang@ef796db5f0 add test for inductive cycle hangs rust-lang@cb6984217f chore: add test case for type with generic rust-lang@0f40b6545d Remove extra check-cfg handled by libc directly rust-lang@803772e81d Enable new capture rules by default on edition 2024 rust-lang@acba7efe1b Add test for implicitly capturing late-bound var with new capture rules rust-lang@0ad160a585 Add lifetime_capture_rules_2024 rust-lang@3f8487a099 Add safe compilation options rust-lang@30a95b7c0a FileCheck while_let_loops. rust-lang@c00068e49f FileCheck tuple_literal_propagation. rust-lang@87522d0007 FileCheck return_place. rust-lang@a12027e128 FileCheck switch_int. rust-lang@19767eb7a6 FileCheck slice_len. rust-lang@3e90c1b434 FileCheck scalar_literal_propagation. rust-lang@f3743aec51 FileCheck repeat. rust-lang@343ef6a9cb FileCheck reify_fn_ptr. rust-lang@6baec3ccc2 FileCheck ref_deref. rust-lang@c8c9207e4c FileCheck read_immutable_static. rust-lang@45dd5d6bf3 FileCheck mutable_variable_unprop_assign. rust-lang@6a8eea8f5b FileCheck mutable_variable_aggregate_partial_read. rust-lang@d91bb5074e FileCheck mutable_variable_no_prop. rust-lang@3e169abc1b FileCheck mutable_variable_aggregate_mut_ref. rust-lang@03c5ad1549 FileCheck mutable_variable_aggregate. rust-lang@ea9f968333 FileCheck mutable_variable. rust-lang@902a3e2e75 FileCheck mult_by_zero. rust-lang@8e9b912c4c FileCheck issue_67019. rust-lang@ce9b1e23a5 FileCheck issue_66971. rust-lang@218d8ccf43 FileCheck inherit_overflow. rust-lang@6086dd6766 FileCheck indirect. rust-lang@bf5d114da8 FileCheck discriminant. rust-lang@043d29b58a FileCheck and rename const_prop_fails_gracefully. rust-lang@7f328d2a44 FileCheck checked_add. rust-lang@e6a1b77cd1 FileCheck cast. rust-lang@b8f2f63931 FileCheck boxes. rust-lang@3fc03948a8 FileCheck boolean_identities. rust-lang@e8e35c8127 FileCheck bad_op_unsafe_oob_for_slices. rust-lang@97f03cb898 FileCheck bad_op_mod_by_zero. rust-lang@0d5bc872a9 FileCheck bad_op_div_by_zero. rust-lang@9f01d9d1b6 FileCheck array_index. rust-lang@6564bac532 FileCheck aggregate. rust-lang@378abbc604 FileCheck address_of_pair. rust-lang@540921e468 Stablize arc_unwrap_or_clone Co-authored-by: celinval <celinval@users.noreply.github.com>

lxy19980601 and others added 10 commits December 5, 2023 14:22

Add safe compilation options

3f8487a

Add two options when building rust: strip and stack protector. If set `strip = true`, symbols will be stripped using `-Cstrip=symbols`. Also can set `stack-protector` and stack protectors will be used.

Remove extra check-cfg handled by libc directly

0f40b65

chore: add test case for type with generic

cb69842

add test for inductive cycle hangs

ef796db

Rollup merge of rust-lang#118775 - Young-Flash:fix, r=compiler-errors

034d73d

chore: add test case for type with generic follow up rust-lang#118502

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 9, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 10, 2023

bors merged commit f7253f2 into rust-lang:master Dec 10, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Dec 10, 2023

bors mentioned this pull request Dec 10, 2023

Netbsd10 update #118738

Merged

This was referenced Dec 10, 2023

Remove unused bootstrap config option #118703

Merged

Generalize LLD usage in bootstrap #116278

Merged

GuillaumeGomez deleted the rollup-fj5wr3q branch December 10, 2023 11:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #118787

Rollup of 5 pull requests #118787

GuillaumeGomez commented Dec 9, 2023

GuillaumeGomez commented Dec 9, 2023

bors commented Dec 9, 2023

bors commented Dec 9, 2023

rust-log-analyzer commented Dec 9, 2023

bors commented Dec 9, 2023

GuillaumeGomez commented Dec 9, 2023

bors commented Dec 10, 2023

bors commented Dec 10, 2023

rust-timer commented Dec 10, 2023

rust-timer commented Dec 10, 2023

Rollup of 5 pull requests #118787

Rollup of 5 pull requests #118787

Conversation

GuillaumeGomez commented Dec 9, 2023

GuillaumeGomez commented Dec 9, 2023

bors commented Dec 9, 2023

bors commented Dec 9, 2023

rust-log-analyzer commented Dec 9, 2023

bors commented Dec 9, 2023

GuillaumeGomez commented Dec 9, 2023

bors commented Dec 10, 2023

bors commented Dec 10, 2023

rust-timer commented Dec 10, 2023

rust-timer commented Dec 10, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size