rustc_span: Remove unused symbols. #118456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
aDotInTheVoid
added
the
C-cleanup
|
As for weather this could be checked automatically in tidy, I don't think there's any easy way to do that, as it can't be answered with any text-based search. |
WaffleLapkin
approved these changes
Nov 29, 2023
|
@bors r=WaffleLapkin |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
@bors rollup=always |
FWIW I tried this previously in #110437 Realized that I never opened a follow-up to remove just the unused symbols 😞 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#118452 (rustdoc-search: allow spaces around `::` in path query) - rust-lang#118453 (Tweak message on ADT with private fields building) - rust-lang#118456 (rustc_span: Remove unused symbols.) - rust-lang#118458 (rustdoc: remove small from `small-section-header`) - rust-lang#118464 (Dispose llvm::TargetMachines prior to llvm::Context being disposed) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2023
Rollup merge of rust-lang#118456 - aDotInTheVoid:unused-symbols, r=WaffleLapkin rustc_span: Remove unused symbols. As noted here, there is no guarantee that all pre-interned symbols are used. https://github.com/rust-lang/rust/blob/b10cfcd65fd7f7b1ab9beb34798b2108de003452/compiler/rustc_span/src/symbol.rs#L124-L125 This was done starting with using ripgrep to search for `sym::whatever`. I removed anything that didn't show up. However this had a huge number of false positives, due to extensive macro use. Then there was a manual phase of adding back all the ones used my macros. I don't think this was worth my time to do, but it's done now . ¯\_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted here, there is no guarantee that all pre-interned symbols are used.
rust/compiler/rustc_span/src/symbol.rs
Lines 124 to 125 in b10cfcd
This was done starting with using ripgrep to search for
sym::whatever. I removed anything that didn't show up. However this had a huge number of false positives, due to extensive macro use. Then there was a manual phase of adding back all the ones used my macros.I don't think this was worth my time to do, but it's done now . ¯_(ツ)_/¯