Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_span: Use correct edit distance start length for suggestions #118381

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Nov 27, 2023

Otherwise the suggestions can be off-base for non-ASCII identifiers. For example suggesting that Ok is a name similar to 读文.

Closes #72553.

Otherwise the suggestions can be off-base for non-ASCII identifiers. For
example suggesting that `Ok` is a name similar to `读文`.
@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 27, 2023
@WaffleLapkin
Copy link
Member

fun

r=me with green CI

@Enselic
Copy link
Member Author

Enselic commented Nov 27, 2023

@bors r=WaffleLapkin rollup

@bors
Copy link
Contributor

bors commented Nov 27, 2023

@Enselic: 🔑 Insufficient privileges: Not in reviewers

@bors
Copy link
Contributor

bors commented Nov 27, 2023

@Enselic: 🔑 Insufficient privileges: not in try users

@Enselic
Copy link
Member Author

Enselic commented Nov 27, 2023

@WaffleLapkin I'll happily get this merged, but you need to @bors delegate=Enselic me first. Thanks for quick review!

@bors
Copy link
Contributor

bors commented Nov 27, 2023

@Enselic: 🔑 Insufficient privileges: Not in reviewers

@WaffleLapkin
Copy link
Member

@Enselic sorry! I saw a [member] github thing and though you had r+privileges.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 27, 2023

📌 Commit 45fc842 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2023
@WaffleLapkin
Copy link
Member

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 27, 2023
rustc_span: Use correct edit distance start length for suggestions

Otherwise the suggestions can be off-base for non-ASCII identifiers. For example suggesting that `Ok` is a name similar to `读文`.

Closes rust-lang#72553.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2023
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#111133 (Detect Python-like slicing and suggest how to fix)
 - rust-lang#114708 (Allow setting `rla` labels via `rustbot`)
 - rust-lang#117526 (Account for `!` arm in tail `match` expr)
 - rust-lang#118341 (Simplify indenting in THIR printing)
 - rust-lang#118366 (Detect and reject malformed `repr(Rust)` hints)
 - rust-lang#118375 (Add -Zunpretty=stable-mir output test)
 - rust-lang#118381 (rustc_span: Use correct edit distance start length for suggestions)
 - rust-lang#118384 (Address unused tuple struct fields in rustdoc)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2023
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#111133 (Detect Python-like slicing and suggest how to fix)
 - rust-lang#114708 (Allow setting `rla` labels via `rustbot`)
 - rust-lang#117526 (Account for `!` arm in tail `match` expr)
 - rust-lang#118172 (Add `pretty_terminator` to pretty stable-mir)
 - rust-lang#118202 (Added linker_arg(s) Linker trait methods for link-arg to be prefixed "-Wl," for cc-like linker args and not verbatim)
 - rust-lang#118374 (QueryContext: rename try_collect_active_jobs -> collect_active_jobs, change return type from Option<QueryMap> to QueryMap)
 - rust-lang#118381 (rustc_span: Use correct edit distance start length for suggestions)
 - rust-lang#118382 (Address unused tuple struct fields in the compiler)
 - rust-lang#118384 (Address unused tuple struct fields in rustdoc)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 344459e into rust-lang:master Nov 28, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 28, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2023
Rollup merge of rust-lang#118381 - Enselic:edit-dist-len, r=WaffleLapkin

rustc_span: Use correct edit distance start length for suggestions

Otherwise the suggestions can be off-base for non-ASCII identifiers. For example suggesting that `Ok` is a name similar to `读文`.

Closes rust-lang#72553.
@Enselic Enselic deleted the edit-dist-len branch November 28, 2023 04:36
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 2, 2023
rustc_hir_typeck: Fix ICE when probing for non-ASCII function alternative

Closes rust-lang#118499

Apparently triggered by rust-lang#118381
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2023
Rollup merge of rust-lang#118514 - Enselic:ice-probe, r=cjgillot

rustc_hir_typeck: Fix ICE when probing for non-ASCII function alternative

Closes rust-lang#118499

Apparently triggered by rust-lang#118381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested spelling correction seems off-base
4 participants