Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #117641

Merged
merged 9 commits into from
Nov 6, 2023
Merged

Rollup of 4 pull requests #117641

merged 9 commits into from
Nov 6, 2023

Commits on Nov 2, 2023

  1. add test for rust-lang#113381 

    Fixes rust-lang#113381

r? fee1-dead
    @matthiaskrgr
    matthiaskrgr committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    384f738 View commit details
    Browse the repository at this point in the history

  2. add test for rust-lang#113375 

    Fixes rust-lang#113375
    @matthiaskrgr
    matthiaskrgr committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    666cad9 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Documentation cleanup for core::error::Request.

    @smarnach
    smarnach committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3a096e9 View commit details
    Browse the repository at this point in the history

  2. check binders with bound vars for global bounds that don't hold 

    (instead of just late bound vars)
    @lqd
    lqd committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2beca15 View commit details
    Browse the repository at this point in the history

  3. add test for trivial bound not holding in soa-derive

    @lqd
    lqd committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    58351ae View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#117190 - matthiaskrgr:test_effects_113381, … 

    …r=fee1-dead

add test for rust-lang#113381

Fixes rust-lang#113381

r? fee1-dead
    @matthiaskrgr
    matthiaskrgr committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1683df7 View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#117516 - matthiaskrgr:test_effects_113375_o… 

    …ob, r=fee1-dead

add test for rust-lang#113375

Fixes rust-lang#113375

r? `@fee1-dead`
    @matthiaskrgr
    matthiaskrgr committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8a34fea View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#117631 - smarnach:error-request-doc-fix, r=… 

    …ChrisDenton

Documentation cleanup for core::error::Request.

This part of the documentation currently render like this:

![image](https://github.com/rust-lang/rust/assets/249196/b34cb907-4ce4-4e85-beca-510d8aa1fefb)

The new version renders like this:

![image](https://github.com/rust-lang/rust/assets/249196/fe18398a-15fb-42a7-82a4-f1856d48bd79)

Fixes:
* Add missing closing back tick.
* Remove spurious double back ticks.
* Add missing newline to render bullet point correctly.
* Fix grammar "there are methods calledrequest_ref and request_value are available" -> "there are methods calledrequest_ref and request_value".
* Change "methods" to "functions", which seems more appropriate for free functions.
    @matthiaskrgr
    matthiaskrgr committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2a1f8bc View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#117637 - lqd:trivial-bounds-with-binder-var… 

    …s, r=compiler-errors

Check binders with bound vars for global bounds that don't hold

This fixes `soa_derive-0.13.0` from rust-lang#117589's crater run.

r? `@compiler-errors`
    @matthiaskrgr
    matthiaskrgr committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9efe60b View commit details
    Browse the repository at this point in the history