Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Clippy #115790

Merged
merged 119 commits into from
Sep 13, 2023
Merged

Update Clippy #115790

merged 119 commits into from
Sep 13, 2023

Conversation

flip1995
Copy link
Member

blyxyas and others added 30 commits April 17, 2023 10:24
Co-authored-by: Nahua <kangnahua@gmail.com>
[`iter_overeager_cloned`]: detect .cloned().all() and .cloned().any()

changelog: [`iter_overeager_cloned`]

r? `@blyxyas`
allow trait alias DefIds in `implements_trait_with_env_from_iter`

Fixes rust-lang#11337

changelog: none
[`arithmetic_side_effects`] Fix rust-lang#11393

Fix rust-lang#11393

```
changelog: [`arithmetic_side_effects`]: Detect division by zero for `Wrapping` and `Saturating`
```
and narrow search span when const/static items are in a mod block
@bors
Copy link
Contributor

bors commented Sep 12, 2023

⌛ Testing commit 2bd6936 with merge efc1a0a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2023
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 12, 2023
@flip1995
Copy link
Member Author

@Alexendoo great catch. Those slipped through while debugging the ICE I fixed in this PR. I removed them

@flip1995
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Sep 12, 2023

📌 Commit d18c0c5 has been approved by flip1995

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 12, 2023
@bors
Copy link
Contributor

bors commented Sep 12, 2023

⌛ Testing commit d18c0c5 with merge b16b5fc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
tests/ui-toml/absolute_paths/absolute_paths.rs (disallow_crates) ... ok
tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.rs ... ok

tests/ui-toml/disallowed_macros/disallowed_macros.rs FAILED:
command: CLIPPY_CONF_DIR="tests/ui-toml/disallowed_macros" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "--extern=clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-f6e1eb189b211467.rlib" "--extern=clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-75959e315c9ff2fe.rlib" "--extern=derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-cf1fe18d496b0b3a.so" "--extern=futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-ff96843d80cd8d4a.rlib" "--extern=if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-08c5e3ddca11c9d5.rlib" "--extern=itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-9aed67eaa870cd55.rlib" "--extern=parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-0d09972064e7da7b.rlib" "--extern=quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-5afd1bb919dc4480.rlib" "--extern=regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-5aefc6c5bb8b6fc1.rlib" "--extern=serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-9a3b80bce0dc30d0.rlib" "--extern=serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-a7b2e5101e0f873f.so" "--extern=syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-7a72a9ecddcd16d5.rlib" "--extern=tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-b072c5f1d078f0c8.rlib" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test" "tests/ui-toml/disallowed_macros/disallowed_macros.rs" "--edition" "2021" "--extern" "macros=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/tests/ui-toml/disallowed_macros/auxiliary/libmacros.rlib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/tests/ui-toml/disallowed_macros/auxiliary"
actual output differed from expected
actual output differed from expected
Execute `cargo uibless` to update `tests/ui-toml/disallowed_macros/disallowed_macros.stderr` to the actual output
--- tests/ui-toml/disallowed_macros/disallowed_macros.stderr
thread 'main' panicked at src/tools/clippy/tests/compile-test.rs:249:6:
called `Result::unwrap()` on an `Err` value: tests failed

Location:
---
   |
LL |     println!("one");
   |     ^^^^^^^^^^^^^^^
   |
   = note: `-D clippy::disallowed-macros` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::disallowed_macros)]`
error: use of a disallowed macro `std::println`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:11:5
   |
   |
LL |     println!("two");

error: use of a disallowed macro `std::cfg`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:12:5
   |
   |
LL |     cfg!(unix);
   |     ^^^^^^^^^^

error: use of a disallowed macro `std::vec`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:13:5
   |
LL |     vec![1, 2, 3];

error: use of a disallowed macro `serde::Serialize`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:15:14
   |
---

error: use of a disallowed macro `macros::expr`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:18:13
   |
LL |     let _ = macros::expr!();

error: use of a disallowed macro `macros::stmt`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:19:5
   |
   |
LL |     macros::stmt!();

error: use of a disallowed macro `macros::pat`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:20:9
   |
   |
LL |     let macros::pat!() = 1;
   |         ^^^^^^^^^^^^^^

error: use of a disallowed macro `macros::ty`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:21:12
   |
LL |     let _: macros::ty!() = "";

error: use of a disallowed macro `macros::item`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:22:5
   |
   |
LL |     macros::item!();
   |     ^^^^^^^^^^^^^^^

error: use of a disallowed macro `macros::binop`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:23:13
   |
LL |     let _ = macros::binop!(1);

error: use of a disallowed macro `macros::attr`
##[error]  --> tests/ui-toml/disallowed_macros/disallowed_macros.rs:28:1
   |

@flip1995
Copy link
Member Author

@bors r=Manishearth

Forgot to re-r+ this.

@bors
Copy link
Contributor

bors commented Sep 13, 2023

📌 Commit 780cbf3 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 13, 2023

⌛ Testing commit 780cbf3 with merge 8142a31...

@bors
Copy link
Contributor

bors commented Sep 13, 2023

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 8142a31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 13, 2023
@bors bors merged commit 8142a31 into rust-lang:master Sep 13, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 13, 2023
@bors bors mentioned this pull request Sep 13, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8142a31): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.211s -> 631.556s (0.05%)
Artifact size: 317.91 MiB -> 317.95 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. subtree-sync PR updates a subtree (miri, clippy, etc). Ignored by no-merges check
Projects
None yet
Development

Successfully merging this pull request may close these issues.