-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: move const prop lints before borrowck #115756
Conversation
…oking the query This allows us to have full control over whether `layout_of` may reveal hidden types
The r-a vscode extension has started `cd`-ing into the current crate's root directory, and then invoking rustfmt. But our rustfmt path is relative, and was then not available.
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
WIP: move const prop lints before borrowck r? `@ghost` for this we need to stop revealing hidden types during const prop and for that I'm opening this WIP PR to do some perf runs
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (7ea1d3c): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 629.551s -> 629.748s (0.03%) |
r? @ghost
for this we need to stop revealing hidden types during const prop
and for that I'm opening this WIP PR to do some perf runs