Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary heap allocation #115425

Merged
merged 1 commit into from
Sep 1, 2023
Merged

remove unnecessary heap allocation #115425

merged 1 commit into from
Sep 1, 2023

Conversation

thechampagne
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Sep 1, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 1, 2023

📌 Commit 9adc6a4 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2023
@bors
Auto merge of rust-lang#115452 - matthiaskrgr:rollup-he30fhv, r=matth…
270eb58 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115411 (miri ABI check: fix handling of 1-ZST; don't accept sign differences)
 - rust-lang#115424 (diagnostics: avoid wrong `unused_parens` on `x as (T) < y`)
 - rust-lang#115425 (remove unnecessary heap allocation)
 - rust-lang#115446 (fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta)
 - rust-lang#115447 (Add comment so pub items are not removed)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cf24a9f into rust-lang:master Sep 1, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thechampagne @rustbot @oli-obk @bors