Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codegen test for trailing_zeros comparison #114850

Merged
merged 1 commit into from
Aug 16, 2023
Merged

add codegen test for trailing_zeros comparison #114850

merged 1 commit into from
Aug 16, 2023

Conversation

khei4
Copy link
Contributor

@khei4 khei4 commented Aug 15, 2023 •
edited by nikic
Loading

This PR add codegen test for
#107554 (comment)

Fixes #107554.

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@khei4 khei4 force-pushed the khei4/trailing_zero_codegen branch from ff6710f to 7b69439 Compare August 15, 2023 13:16
@nikic
Copy link
Contributor

nikic commented Aug 15, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 15, 2023

📌 Commit 7b69439 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 15, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#114850 - khei4:khei4/trailing_zero_codegen,…
b0896e1 
… r=nikic

add codegen test for `trailing_zeros` comparison

This PR add codegen test for
rust-lang#107554 (comment)

Fixes rust-lang#107554.
@matthiaskrgr
Copy link
Member

@bors r-
#114857 (comment)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#114850 - khei4:khei4/trailing_zero_codegen,…
b06df00 
… r=nikic

add codegen test for `trailing_zeros` comparison

This PR add codegen test for
rust-lang#107554 (comment)

Fixes rust-lang#107554.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 15, 2023
Closed
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2023
@khei4
add codegen test for issue 107554
8d514f2 
specify llvm-version and bit width for int arg

add missing percent simbol
@khei4 khei4 force-pushed the khei4/trailing_zero_codegen branch from 7b69439 to 8d514f2 Compare August 16, 2023 05:04
@khei4 khei4 marked this pull request as ready for review August 16, 2023 05:59
@nikic
Copy link
Contributor

nikic commented Aug 16, 2023

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 16, 2023

📌 Commit 8d514f2 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2023
@bors
Copy link
Contributor

bors commented Aug 16, 2023

⌛ Testing commit 8d514f2 with merge 1ec628d...

@bors
Copy link
Contributor

bors commented Aug 16, 2023

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 1ec628d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2023
@bors bors merged commit 1ec628d into rust-lang:master Aug 16, 2023
12 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1ec628d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.6% [0.6%, 0.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.431s -> 635.223s (0.12%)
Artifact size: 346.89 MiB -> 346.78 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Suboptimal code generated for alignment checks and similar via number.trailing_zeros() >= bit_count
8 participants
@khei4 @rustbot @rust-log-analyzer @nikic @bors @matthiaskrgr @rust-timer @Mark-Simulacrum