Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canonicalize in inspect, work towards intercrate_ambiguity_causes support #114810

Closed
wants to merge 8 commits into from
Closed

canonicalize in inspect, work towards intercrate_ambiguity_causes support #114810

wants to merge 8 commits into from

Commits on Aug 14, 2023

  1. split GoalEvaluation and CanonicalGoalEvaluation 

    the unnormalized goal is in the callers inference context, while
anything inside of the `CanonicalGoalEvaluation` is inside of
a new one.
    @lcnr
    lcnr committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    2900c6d View commit details
    Browse the repository at this point in the history

  2. inspect: handle None in nested

    @lcnr
    lcnr committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    27e4877 View commit details
    Browse the repository at this point in the history

  3. revision -> iteration for added_goals_evaluation

    @lcnr
    lcnr committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    55a7f9f View commit details
    Browse the repository at this point in the history

  4. canonicalize everything in nested goals

    @lcnr
    lcnr committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    c12e623 View commit details
    Browse the repository at this point in the history

  5. wip, support intercrate_ambiguity_causes

    @lcnr
    lcnr committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    121195a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. inspect::CandidateKind -> ProbeKind 

    add `TraitCandidate` variant using `CandidateSource`
    @lcnr
    lcnr committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1a0f7ac View commit details
    Browse the repository at this point in the history

  2. change MiscCandidate::name to &'static str

    @lcnr
    lcnr committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9678985 View commit details
    Browse the repository at this point in the history

  3. wip very uwu

    @lcnr
    lcnr committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8b63304 View commit details
    Browse the repository at this point in the history