Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for issue #113941 - naive layout isn't refined #113957

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Add regression test for issue #113941 - naive layout isn't refined #113957

merged 1 commit into from
Jul 22, 2023

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jul 22, 2023

This PR adds a regression test for issue #113941 - the naive layout isn't refined by the actual layout based on the minimized repro #113941 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 22, 2023
dtolnay
dtolnay approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Jul 22, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 22, 2023

📌 Commit ffa4b6f has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2023
@dtolnay dtolnay assigned dtolnay and unassigned b-naber Jul 22, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2023
@bors
Auto merge of rust-lang#113968 - matthiaskrgr:rollup-7vdfcba, r=matth…
a6fbd1c 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112508 (Tweak spans for self arg, fix borrow suggestion for signature mismatch)
 - rust-lang#113901 (Get rid of subst-relate incompleteness in new solver)
 - rust-lang#113948 (Fix rustc-args passing issue in bootstrap)
 - rust-lang#113950 (Remove Scope::Elision from bound-vars resolution.)
 - rust-lang#113957 (Add regression test for issue rust-lang#113941 - naive layout isn't refined)
 - rust-lang#113959 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7183bd into rust-lang:master Jul 22, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 22, 2023
@Urgau Urgau deleted the regression-test-issue-113941 branch July 22, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Urgau @rustbot @dtolnay @bors @b-naber