Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WF/ConstEvaluatable goal to clause #112667

Merged
merged 3 commits into from
Jun 18, 2023

Conversation

compiler-errors
Copy link
Member

It can show up in a param-env, so I think it needs to be a clause kind.

r? @lcnr or @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative labels Jun 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member Author

astconv is too large 🤦

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2023

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

@compiler-errors compiler-errors changed the title Move WF goal to clause Move WF/ConstEvaluatable goal to clause Jun 15, 2023
@rust-log-analyzer

This comment has been minimized.

Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with tidy happy

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved
@compiler-errors
Copy link
Member Author

Moved some files around astconv to appease tidy, since that file is huge.

r? @oli-obk @bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 16, 2023

📌 Commit 92a2bbd has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned lcnr Jun 16, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 17, 2023
… r=oli-obk

Move WF/ConstEvaluatable goal to clause

It can show up in a param-env, so I think it needs to be a clause kind.

r? `@lcnr` or `@oli-obk`
@matthiaskrgr
Copy link
Member

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 17, 2023
@compiler-errors
Copy link
Member Author

compiler-errors commented Jun 17, 2023

Yeah, conflicted with another pr of mine.

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Jun 17, 2023

📌 Commit 4343d36 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 17, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 18, 2023
… r=lcnr

Move WF/ConstEvaluatable goal to clause

It can show up in a param-env, so I think it needs to be a clause kind.

r? `@lcnr` or `@oli-obk`
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 18, 2023
… r=lcnr

Move WF/ConstEvaluatable goal to clause

It can show up in a param-env, so I think it needs to be a clause kind.

r? ``@lcnr`` or ``@oli-obk``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 18, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#107200 (io: soften ‘at most one write attempt’ requirement in io::Write::write)
 - rust-lang#112667 (Move WF/ConstEvaluatable goal to clause)
 - rust-lang#112685 (std: only depend on dlmalloc for wasm*-unknown)
 - rust-lang#112722 (bootstrap: check for dry run when copying env vars for msvc)
 - rust-lang#112734 (Make `Bound::predicates`  use `Clause`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8d3d3cc into rust-lang:master Jun 18, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jun 18, 2023
@compiler-errors compiler-errors deleted the wf-goal-is-clause branch August 11, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants