Group rfcs tests #112071

WaffleLapkin · 2023-05-29T15:47:30Z

This moves all RFC tests to tests/ui/rfcs/rfc-NNNN-title-title-title/...

I had to rename some tests due to conflicts, but otherwise this is just a move.

rustbot · 2023-05-29T15:47:37Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

oli-obk · 2023-05-30T08:44:27Z

r=me after a rebase

@bors rollup

WaffleLapkin · 2023-05-30T11:53:33Z

@bors r=oli-obk

bors · 2023-05-30T11:53:35Z

📌 Commit b694a03 has been approved by oli-obk

It is now in the queue for this repository.

…li-obk Group rfcs tests This moves all RFC tests to `tests/ui/rfcs/rfc-NNNN-title-title-title/...` I had to rename some tests due to conflicts, but otherwise this is just a move.

Rollup of 7 pull requests Successful merges: - rust-lang#108459 (rustdoc: Fix LinkReplacer link matching) - rust-lang#111318 (Add a distinct `OperandValue::ZeroSized` variant for ZSTs) - rust-lang#111892 (rustdoc: add interaction delays for tooltip popovers) - rust-lang#111980 (Preserve substs in opaques recorded in typeck results) - rust-lang#112024 (Don't suggest break through nested items) - rust-lang#112128 (Don't compute inlining status of mono items in advance.) - rust-lang#112141 (remove reference to Into in ? operator core/std docs, fix rust-lang#111655) Failed merges: - rust-lang#112071 (Group rfcs tests) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#111670 (Require that const param tys implement `ConstParamTy`) - rust-lang#111914 (CFI: Fix cfi with async: transform_ty: unexpected GeneratorWitness(Bi…) - rust-lang#112030 (Migrate `item_trait_alias` to Askama) - rust-lang#112150 (Support 128-bit atomics on all x86_64 Apple targets) - rust-lang#112174 (Fix broken link) - rust-lang#112190 (Improve comments on `TyCtxt` and `GlobalCtxt`.) - rust-lang#112193 (Check tuple elements are `Sized` in `offset_of`) Failed merges: - rust-lang#112071 (Group rfcs tests) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2023-06-02T09:19:29Z

@bors rollup=never prone to merge conflicts

bors · 2023-06-02T14:03:30Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout group-rfcs-tests (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self group-rfcs-tests --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Removing tests/ui/rfc-2005-default-binding-mode/slice.rs
Removing tests/ui/rfc-2005-default-binding-mode/lit.rs
Removing tests/ui/rfc-2005-default-binding-mode/for.rs
Removing tests/ui/rfc-2005-default-binding-mode/enum.rs
Auto-merging src/tools/tidy/src/ui_tests.rs
CONFLICT (content): Merge conflict in src/tools/tidy/src/ui_tests.rs
Automatic merge failed; fix conflicts and then commit the result.

petrochenkov · 2023-06-03T21:14:06Z

I don't think this is an improvement, the rfcs directory is artificial, meaningless by itself, and doesn't map to a WG or a set of people that work on a specific compiler area and could maintain the corresponding subset of tests.

I think specific rfc-NNNN-feature-name subdirectories should be moved to "semantically meaningful" subdirectories like privacy, or lexer, or auto-traits or whatever.

cc #73494

WaffleLapkin · 2023-06-05T17:28:42Z

@petrochenkov I agree that rfcs/ does not make much sense in the long run and we should sort things better, however in the meantime it makes sense to use the same style for all RFCs, even if eventually we won't have rfc-specific directories at all.

@bors r=oli-obk

bors · 2023-06-05T17:28:44Z

📌 Commit 18e016f has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-06-05T19:36:21Z

⌛ Testing commit 18e016f with merge e6d4725...

bors · 2023-06-05T22:44:51Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing e6d4725 to master...

rust-timer · 2023-06-05T23:59:37Z

Finished benchmarking commit (e6d4725): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.4%	[5.4%, 5.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 645.696s -> 647.875s (0.34%)

petrochenkov · 2023-06-07T15:41:05Z

@WaffleLapkin
It's not useful in a short turn either, it only creates churn in git history and adds one more directory to the list of meaningless directories to be dismantled.
Reverting this doesn't make sense because that would only add more churn, but I wish I r- this PR more explicitly to prevent it from landing.
Please, do not move any more tests mechanically, like in this PR.

It's not necessary to dismantle the rfc-NNNN-feature-name directories immediately, they can be moved to meaningful subdirectories as whole too.

WaffleLapkin · 2023-06-08T12:30:13Z

adds one more directory to the list of meaningless directories to be dismantled.

rfcs/ already existed, so this does not change the list.

…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#111670 (Require that const param tys implement `ConstParamTy`) - rust-lang#111914 (CFI: Fix cfi with async: transform_ty: unexpected GeneratorWitness(Bi…) - rust-lang#112030 (Migrate `item_trait_alias` to Askama) - rust-lang#112150 (Support 128-bit atomics on all x86_64 Apple targets) - rust-lang#112174 (Fix broken link) - rust-lang#112190 (Improve comments on `TyCtxt` and `GlobalCtxt`.) - rust-lang#112193 (Check tuple elements are `Sized` in `offset_of`) Failed merges: - rust-lang#112071 (Group rfcs tests) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned oli-obk May 29, 2023

rust-cloud-vms bot force-pushed the group-rfcs-tests branch from 542961f to b694a03 Compare May 30, 2023 11:51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2023

WaffleLapkin mentioned this pull request May 30, 2023

Move tests from ui/discrim dir #112068

Merged

Dylan-DPC mentioned this pull request May 30, 2023

Rollup of 6 pull requests #112111

Closed

Dylan-DPC mentioned this pull request Jun 1, 2023

Rollup of 7 pull requests #112164

Merged

matthiaskrgr mentioned this pull request Jun 1, 2023

Rollup of 8 pull requests #112181

Closed

compiler-errors mentioned this pull request Jun 2, 2023

Rollup of 7 pull requests #112198

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2023

WaffleLapkin added 2 commits June 5, 2023 16:09

Better group RFC ui tests together

9d3482c

Bless tidy root entry limit

18e016f

rust-cloud-vms bot force-pushed the group-rfcs-tests branch from b694a03 to 18e016f Compare June 5, 2023 17:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2023

bors merged commit e6d4725 into rust-lang:master Jun 5, 2023

rustbot added this to the 1.72.0 milestone Jun 5, 2023

rustbot added the perf-regression Performance regression. label Jun 5, 2023

Mark-Simulacrum removed the perf-regression Performance regression. label Jun 6, 2023

WaffleLapkin deleted the group-rfcs-tests branch June 8, 2023 12:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Group rfcs tests #112071

Group rfcs tests #112071

WaffleLapkin commented May 29, 2023

rustbot commented May 29, 2023

oli-obk commented May 30, 2023

WaffleLapkin commented May 30, 2023

bors commented May 30, 2023

matthiaskrgr commented Jun 2, 2023

bors commented Jun 2, 2023

petrochenkov commented Jun 3, 2023

WaffleLapkin commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

rust-timer commented Jun 5, 2023

petrochenkov commented Jun 7, 2023

WaffleLapkin commented Jun 8, 2023

Group rfcs tests #112071

Group rfcs tests #112071

Conversation

WaffleLapkin commented May 29, 2023

rustbot commented May 29, 2023

oli-obk commented May 30, 2023

WaffleLapkin commented May 30, 2023

bors commented May 30, 2023

matthiaskrgr commented Jun 2, 2023

bors commented Jun 2, 2023

petrochenkov commented Jun 3, 2023

WaffleLapkin commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

rust-timer commented Jun 5, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

petrochenkov commented Jun 7, 2023

WaffleLapkin commented Jun 8, 2023