Update current implementation comments for select_nth_unstable
#111973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#111714 (Stop confusing specification levels when computing expectations.) - rust-lang#111927 (Migrate `item_static` to Askama) - rust-lang#111954 (improve error message for calling a method on a raw pointer with an unknown pointee) - rust-lang#111973 (Update current implementation comments for `select_nth_unstable`) - rust-lang#111976 (Generate docs for bootstrap itself) - rust-lang#111977 (Make errors from `x doc` less verbose) - rust-lang#111987 (do not prefer substs relate during coherence) - rust-lang#111991 (Change ty and const error's pretty printing to be in braces) r? `@ghost` `@rustbot` modify labels: rollup
This was referenced May 28, 2023
Merged
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 29, 2023
Followup to rust-lang#111973 I somehow forgot to update the comment on `select_nth_unstable_by_key` in rust-lang#111973, so this PR fixes that. r? `@Amanieu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112029 (Recover upon mistyped error on typo'd `const` in const param def) - rust-lang#112037 (Add details about `unsafe_op_in_unsafe_fn` to E0133) - rust-lang#112039 (compiler: update solaris/illumos to enable tsan support.) - rust-lang#112042 (Migrate GUI colors test to original CSS color format) - rust-lang#112045 (Followup to rust-lang#111973) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more accurately reflects the actual implementation, as it hasn't been a simple quickselect since #106997. While it does say that the current implementation always runs in O(n), I don't think it should require an FCP as it doesn't guarantee linearity in general and only points out that the current implementation is in fact linear.
r? @Amanieu