Add build instructions for cranelift backend as part of Rust repo #111827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
|
This makes sense to have, thanks. I think there are a couple of things that can be simplified here. I will try it later and report back with what worked. |
AngelicosPhosphoros
force-pushed
the
add_docs_to_cranelift
branch
from
82fd128
to
8ba2a66
Compare
bjorn3
reviewed
May 22, 2023
AngelicosPhosphoros
force-pushed
the
add_docs_to_cranelift
branch
from
8ba2a66
to
ed3d661
Compare
|
@bjorn3 I updated PR. I make little different changes than some you requested, I hope that is OK. |
All other instructions assume that user works with separate repository than Rust compiler repository. When one follows default instructions, cranelift codegen tries to use different sys-root and compiler internal crates which leads to compiler errors when building it. I needed to do all this steps while adding new intrinsic to rustc.
AngelicosPhosphoros
force-pushed
the
add_docs_to_cranelift
branch
from
ed3d661
to
38c712f
Compare
|
Thanks! @bors r+ rollup=always |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111558 (Move tests) - rust-lang#111827 (Add build instructions for cranelift backend as part of Rust repo) - rust-lang#111988 (Make `TyKind: Debug` have less verbose output) - rust-lang#112022 (Check nested obligations during coercion unify in new solver) - rust-lang#112057 (Suggest correct `self_ty`) - rust-lang#112063 (Add a test for issue 110457/incremental ICE with closures with the same span) Failed merges: - rust-lang#112068 (Move tests from `ui/discrim` dir) r? `@ghost` `@rustbot` modify labels: rollup
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Jun 15, 2023
…anelift, r=bjorn3 Add build instructions for cranelift backend as part of Rust repo All other instructions assume that user works with separate repository than Rust compiler repository. When one follows default instructions, cranelift codegen tries to use different sys-root and compiler internal crates which leads to compiler errors when building it. I needed to do all this steps while adding new intrinsic to rustc. r? bjorn3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other instructions assume that user works with separate repository than Rust compiler repository. When one follows default instructions, cranelift codegen tries to use different sys-root and compiler internal crates which leads to compiler errors when building it.
I needed to do all this steps while adding new intrinsic to rustc.
r? bjorn3