Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #111304

Merged
merged 14 commits into from
May 7, 2023
Merged

Rollup of 7 pull requests #111304

merged 14 commits into from
May 7, 2023

Commits on Apr 30, 2023

  1. Fix the test directories suggested by ./x.py suggest

    The tests that were in `src/test/` have been moved to `tests/`, so the paths
    given by the suggestion tool should reflect this.
    Zalathar committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    71ab284 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Make ConstProp tests unit.

    cjgillot committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a4ef2f5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. check bootstrap scripts syntax

    Signed-off-by: ozkanonur <work@onurozkan.dev>
    onur-ozkan committed May 3, 2023
    Configuration menu
    Copy the full SHA
    eea6202 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Configuration menu
    Copy the full SHA
    00ac29d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    08fc451 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Expand the LLVM coverage of --print target-cpus

    We've been relying on a custom patch to add `MCSubtargetInfo::getCPUTable`
    for `rustc --print target-cpus`, and just printing that it's not supported
    on external LLVM builds. LLVM `main` now has `getAllProcessorDescriptions`
    that can replace ours, so now we try to use that. In addition, the fallback
    path can at least print the native and default cpu options.
    
    There were also some mismatches in the function signatures here between
    `LLVM_RUSTLLVM` and otherwise; this is now mitigated by sharing these
    functions and only using cpp to adjust the function bodies.
    cuviper committed May 6, 2023
    Configuration menu
    Copy the full SHA
    67ae38a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9027d20 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#111002 - Zalathar:x-suggest-dirs, r=Mark-Si…

    …mulacrum
    
    Fix the test directories suggested by `./x.py suggest`
    
    It seems that these paths were correct when rust-lang#106249 was being written, but since then rust-lang#106458 has been merged (moving `src/test/` to `tests/`), making the tool's suggestions incorrect.
    matthiaskrgr committed May 6, 2023
    Configuration menu
    Copy the full SHA
    cec5c40 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#111077 - cjgillot:const-prop-unit, r=Mark-S…

    …imulacrum
    
    Make more ConstProp tests unit.
    matthiaskrgr committed May 6, 2023
    Configuration menu
    Copy the full SHA
    bccd296 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#111151 - ozkanonur:syntax-check-on-bootstra…

    …p-scripts, r=Mark-Simulacrum
    
    check bootstrap scripts syntax
    
    Fails bootstrapping if `x`/`x.ps1` scripts are not valid. Currently, it keeps executing lines until the invalid one.
    matthiaskrgr committed May 6, 2023
    Configuration menu
    Copy the full SHA
    60db448 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#111203 - Kobzol:remark-print-kind, r=tmiasko

    Output LLVM optimization remark kind in `-Cremark` output
    
    Since rust-lang#90833, the optimization remark kind has not been printed. Therefore it wasn't possible to easily determine from the log (in a programmatic way) which remark kind was produced. I think that the most interesting remarks are the missed ones, which can lead users to some code optimization.
    
    Maybe we could also change the format closer to the "old" one:
    ```
    note: optimization remark for tailcallelim at /checkout/src/libcore/num/mod.rs:1:0: marked this call a tail call candidate
    ```
    
    I wanted to programatically parse the remarks so that they could work e.g. with https://github.com/OfekShilon/optview2. However, now that I think about it, probably the proper solution is to tell rustc to output them to YAML and then use the YAML as input for the opt remark visualization tools. The flag for enabling this does not seem to work though (rust-lang#96705 (comment)).
    
    Still I think that it's good to output the remark kind anyway, it's an important piece of information.
    
    r? ```@tmiasko```
    matthiaskrgr committed May 6, 2023
    Configuration menu
    Copy the full SHA
    e4eaf31 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#111237 - loongarch-rs:clobber-abi, r=Amanieu

    asm: loongarch64: Implementation of clobber_abi
    
    r? ```@Amanieu```
    matthiaskrgr committed May 6, 2023
    Configuration menu
    Copy the full SHA
    a3af532 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#111274 - cuviper:print-target-cpus, r=Mark-…

    …Simulacrum
    
    Expand the LLVM coverage of `--print target-cpus`
    
    We've been relying on a custom patch to add `MCSubtargetInfo::getCPUTable`
    for `rustc --print target-cpus`, and just printing that it's not supported
    on external LLVM builds. LLVM `main` now has `getAllProcessorDescriptions`
    that can replace ours, so now we try to use that. In addition, the fallback
    path can at least print the native and default cpu options.
    
    There were also some mismatches in the function signatures here between
    `LLVM_RUSTLLVM` and otherwise; this is now mitigated by sharing these
    functions and only using cpp to adjust the function bodies.
    matthiaskrgr committed May 6, 2023
    Configuration menu
    Copy the full SHA
    ecc0615 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#111289 - clubby789:fix-111280, r=jyn514

    Check arguments length in trivial diagnostic lint
    
    Fixes rust-lang#111280
    matthiaskrgr committed May 6, 2023
    Configuration menu
    Copy the full SHA
    1de257b View commit details
    Browse the repository at this point in the history