Don't suffix RibKind variants
#111070
Merged
Don't suffix RibKind variants
#111070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 3, 2023
Don't suffix `RibKind` variants
This PR
- Removes `use RibKind::*`
- Renames `RibKind::{SomethingRibKind => Something}`
It seems unnecessary to have "RibKind" in the end of all variants, if we can just use it as a normal enum. Additionally previously it was weird that `MacroDefinition` is the only unsuffixed variant.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 3, 2023
Don't suffix `RibKind` variants
This PR
- Removes `use RibKind::*`
- Renames `RibKind::{SomethingRibKind => Something}`
It seems unnecessary to have "RibKind" in the end of all variants, if we can just use it as a normal enum. Additionally previously it was weird that `MacroDefinition` is the only unsuffixed variant.
bors
added
S-waiting-on-author
|
@Dylan-DPC why do you think this PR is the cause? The failure is with uploading artifacts to S3: This pr did not touch |
|
I think something is wrong with the log viewer, but if you check the raw log it shows you the entire error. But i don't see the option to view raw logs any more so i guess we'll just retry it and see what happens |
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110859 (Explicitly reject negative and reservation drop impls) - rust-lang#111020 (Validate resolution for SelfCtor too.) - rust-lang#111024 (Use the full Fingerprint when stringifying Svh) - rust-lang#111027 (Remove `allow(rustc::potential_query_instability)` for `builtin_macros`) - rust-lang#111039 (Encode def span for foreign return-position `impl Trait` in trait) - rust-lang#111070 (Don't suffix `RibKind` variants) - rust-lang#111094 (Add needs-unwind annotations to tests that need stack unwinding) - rust-lang#111103 (correctly recurse when expanding anon consts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
use RibKind::*RibKind::{SomethingRibKind => Something}It seems unnecessary to have "RibKind" in the end of all variants, if we can just use it as a normal enum. Additionally previously it was weird that
MacroDefinitionis the only unsuffixed variant.